database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](memory) fix set disable_chunk_allocator_in_vec=false performance #12092

Browse Source
This commit is contained in:
Xinyi Zou
2022-08-26 14:28:12 +08:00
committed by GitHub
parent 89d6f1231f
commit 9caaa4bfbd
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
be/src/common/config.h
View File

@ -456,7 +456,7 @@ CONF_Int32(min_chunk_reserved_bytes, "1024");
// of gperftools tcmalloc central lock.
// Jemalloc or google tcmalloc have core cache, Chunk Allocator may no longer be needed after replacing
// gperftools tcmalloc.
CONF_mBool(disable_chunk_allocator_in_vec, "true");
CONF_mBool(disable_chunk_allocator_in_vec, "false");
// The probing algorithm of partitioned hash table.
// Enable quadratic probing hash table

3
be/src/vec/common/allocator.h
View File

@ -195,7 +195,7 @@ public:
if (old_size == new_size) {
/// nothing to do.
/// BTW, it's not possible to change alignment while doing realloc.
} else if (old_size < MMAP_THRESHOLD && new_size < MMAP_THRESHOLD &&
} else if (old_size < CHUNK_THRESHOLD && new_size < CHUNK_THRESHOLD &&
alignment <= MALLOC_MIN_ALIGNMENT) {
/// Resize malloc'd memory region with no special alignment requirement.
void* new_buf = ::realloc(buf, new_size);
@ -233,6 +233,7 @@ public:
memset(reinterpret_cast<char*>(buf) + old_size, 0, new_size - old_size);
}
} else {
// CHUNK_THRESHOLD <= old_size <= MMAP_THRESHOLD use system realloc is slow, use ChunkAllocator.
// Big allocs that requires a copy.
void* new_buf = alloc(new_size, alignment);
memcpy(new_buf, buf, std::min(old_size, new_size));