database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

branch-2.1: [fix](case) fix group commit case #53292 (#53431)

Browse Source 
Cherry-picked from #53292

Co-authored-by: meiyi <myimeiyi@gmail.com>
This commit is contained in:
github-actions[bot]
2025-07-27 15:59:20 +08:00
committed by GitHub
parent 372627231c
commit a86a8f5e57
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
be/src/runtime/group_commit_mgr.cpp
View File

@ -398,13 +398,15 @@ Status GroupCommitTable::_finish_group_commit_load(int64_t db_id, int64_t table_
RuntimeState* state) {
Status st;
Status result_status;
DBUG_EXECUTE_IF("LoadBlockQueue._finish_group_commit_load.err_status",
{ status = Status::InternalError(""); });
DBUG_EXECUTE_IF("LoadBlockQueue._finish_group_commit_load.err_status", {
status = Status::InternalError("LoadBlockQueue._finish_group_commit_load.err_status");
});
DBUG_EXECUTE_IF("LoadBlockQueue._finish_group_commit_load.load_error",
{ status = Status::InternalError("load_error"); });
if (status.ok()) {
DBUG_EXECUTE_IF("LoadBlockQueue._finish_group_commit_load.commit_error",
{ status = Status::InternalError(""); });
DBUG_EXECUTE_IF("LoadBlockQueue._finish_group_commit_load.commit_error", {
status = Status::InternalError("LoadBlockQueue._finish_group_commit_load.commit_error");
});
// commit txn
TLoadTxnCommitRequest request;
request.__set_auth_code(0); // this is a fake, fe not check it now
@ -479,8 +481,9 @@ Status GroupCommitTable::_finish_group_commit_load(int64_t db_id, int64_t table_
// status: exec_plan_fragment result
// st: commit txn rpc status
// result_status: commit txn result
DBUG_EXECUTE_IF("LoadBlockQueue._finish_group_commit_load.err_st",
{ st = Status::InternalError(""); });
DBUG_EXECUTE_IF("LoadBlockQueue._finish_group_commit_load.err_st", {
st = Status::InternalError("LoadBlockQueue._finish_group_commit_load.err_st");
});
if (status.ok() && st.ok() &&
(result_status.ok() || result_status.is<ErrorCode::PUBLISH_TIMEOUT>())) {
if (!config::group_commit_wait_replay_wal_finish) {

4
regression-test/suites/fault_injection_p0/test_group_commit_async_wal_msg_fault_injection.groovy
View File

@ -156,7 +156,7 @@ suite("test_group_commit_async_wal_msg_fault_injection","nonConcurrent") {
) engine=olap
DISTRIBUTED BY HASH(`k`)
BUCKETS 5
properties("replication_num" = "1", "group_commit_interval_ms" = "4000")
properties("replication_num" = "1", "group_commit_interval_ms" = "10000")
"""
GetDebugPoint().clearDebugPointsForAllBEs()
try {
@ -167,7 +167,7 @@ suite("test_group_commit_async_wal_msg_fault_injection","nonConcurrent") {
set 'group_commit', 'async_mode'
unset 'label'
file 'group_commit_wal_msg.csv'
time 10000
time 6000
}
getRowCount(5)
} finally {