database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](spark-load) fix Roaring64Map big-endian read/write in de/serialization (#7480)

Browse Source 
See #7479
This bug is triggered when the bitmap exceeds 32 bits.
This commit is contained in:
Xiang Wei
2021-12-26 11:09:50 +08:00
committed by GitHub
parent 43e93180c5
commit ab60c5eb59
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fe/fe-common/src/main/java/org/apache/doris/common/io/Roaring64Map.java
View File

@ -1322,7 +1322,8 @@ public class Roaring64Map {
Codec.encodeVarint64(highToBitmap.size(), out);
for (Map.Entry<Integer, BitmapDataProvider> entry : highToBitmap.entrySet()) {
out.writeInt(entry.getKey().intValue());
// serialized in little end for BE cpp read in case of bugs when the value is larger than 32bits
out.writeInt(Integer.reverseBytes(entry.getKey().intValue()));
entry.getValue().serialize(out);
}
}
@ -1356,7 +1357,8 @@ public class Roaring64Map {
long nbHighs = Codec.decodeVarint64(in);
for (int i = 0; i < nbHighs; i++) {
int high = in.readInt();
// keep the same behavior with little-end serialize
int high = Integer.reverseBytes(in.readInt());
RoaringBitmap provider = new RoaringBitmap();
provider.deserialize(in);
highToBitmap.put(high, provider);