database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[performance](executor) remove repeated call within the loop in validate_column

Browse Source
This commit is contained in:
Mryange
2023-06-09 19:59:25 +08:00
committed by GitHub
parent 54504fb61d
commit abb2048d5d
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
be/src/vec/sink/vtablet_sink.cpp
View File

@ -1689,7 +1689,8 @@ Status VOlapTableSink::_validate_column(RuntimeState* state, const TypeDescripto
auto column_decimal = const_cast<vectorized::ColumnDecimal<vectorized::Decimal128>*>(
assert_cast<const vectorized::ColumnDecimal<vectorized::Decimal128>*>(
real_column_ptr.get()));
const auto& max_decimalv2 = _get_decimalv2_min_or_max<false>(type);
const auto& min_decimalv2 = _get_decimalv2_min_or_max<true>(type);
for (size_t j = 0; j < column->size(); ++j) {
auto row = rows ? (*rows)[j] : j;
if (row == last_invalid_row) {
@ -1710,8 +1711,6 @@ Status VOlapTableSink::_validate_column(RuntimeState* state, const TypeDescripto
invalid = true;
}
}
const auto& max_decimalv2 = _get_decimalv2_min_or_max<false>(type);
const auto& min_decimalv2 = _get_decimalv2_min_or_max<true>(type);
if (dec_val > max_decimalv2 || dec_val < min_decimalv2) {
fmt::format_to(error_msg, "{}", "decimal value is not valid for definition");
fmt::format_to(error_msg, ", value={}", dec_val.to_string());
@ -1735,6 +1734,8 @@ Status VOlapTableSink::_validate_column(RuntimeState* state, const TypeDescripto
auto column_decimal = const_cast<vectorized::ColumnDecimal<vectorized::ColumnDecimalType>*>( \
assert_cast<const vectorized::ColumnDecimal<vectorized::ColumnDecimalType>*>( \
real_column_ptr.get())); \
const auto& max_decimal = _get_decimalv3_min_or_max<vectorized::DecimalType, false>(type); \
const auto& min_decimal = _get_decimalv3_min_or_max<vectorized::DecimalType, true>(type); \
for (size_t j = 0; j < column->size(); ++j) { \
auto row = rows ? (*rows)[j] : j; \
if (row == last_invalid_row) { \
@ -1743,10 +1744,6 @@ Status VOlapTableSink::_validate_column(RuntimeState* state, const TypeDescripto
if (need_to_validate(j, row)) { \
auto dec_val = column_decimal->get_data()[j]; \
bool invalid = false; \
const auto& max_decimal = \
_get_decimalv3_min_or_max<vectorized::DecimalType, false>(type); \
const auto& min_decimal = \
_get_decimalv3_min_or_max<vectorized::DecimalType, true>(type); \
if (dec_val > max_decimal || dec_val < min_decimal) { \
fmt::format_to(error_msg, "{}", "decimal value is not valid for definition"); \
fmt::format_to(error_msg, ", value={}", dec_val); \