database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](be): fix stack overflow in unhex function (#11204)

Browse Source 
* [fix](be): fix stack overflow in unhex function
This commit is contained in:
spaces-x
2022-07-28 14:59:54 +08:00
committed by GitHub
parent 19b34c09b1
commit b260a02215
4 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
be/src/exprs/math_functions.cpp
View File

@ -381,7 +381,8 @@ StringVal MathFunctions::unhex(FunctionContext* ctx, const StringVal& s) {
}
int result_len = s.len / 2;
char result[result_len];
StringVal result_string_val(ctx, result_len);
char* result = reinterpret_cast<char*>(result_string_val.ptr);
int res_index = 0;
int s_index = 0;
while (s_index < s.len) {
@ -426,7 +427,7 @@ StringVal MathFunctions::unhex(FunctionContext* ctx, const StringVal& s) {
result[res_index] = c;
++res_index;
}
return AnyValUtil::from_buffer_temp(ctx, result, result_len);
return result_string_val;
}
StringVal MathFunctions::conv_int(FunctionContext* ctx, const BigIntVal& num,

4
be/src/udf/udf.cpp
View File

@ -209,11 +209,11 @@ FunctionContext* FunctionContextImpl::clone(MemPool* pool) {
namespace doris_udf {
static const int MAX_WARNINGS = 1000;
FunctionContext* FunctionContext::create_test_context() {
FunctionContext* FunctionContext::create_test_context(doris::MemPool* mem_pool = nullptr) {
FunctionContext* context = new FunctionContext();
context->impl()->_debug = true;
context->impl()->_state = nullptr;
context->impl()->_pool = new doris::FreePool(nullptr);
context->impl()->_pool = new doris::FreePool(mem_pool);
return context;
}

4
be/src/udf/udf.h
View File

@ -37,6 +37,7 @@ class BitmapValue;
class DecimalV2Value;
class DateTimeValue;
class CollectionValue;
class MemPool;
} // namespace doris
namespace doris_udf {
@ -255,7 +256,8 @@ public:
// Create a test FunctionContext object. The caller is responsible for calling delete
// on it. This context has additional debugging validation enabled.
static FunctionContext* create_test_context();
// And the default value of mem_pool is nullprt.
static FunctionContext* create_test_context(doris::MemPool* mem_pool);
~FunctionContext();

5
be/test/exprs/math_functions_test.cpp
View File

@ -23,6 +23,7 @@
#include <string>
#include "runtime/large_int_value.h"
#include "runtime/mem_pool.h"
#include "testutil/function_utils.h"
#include "udf/udf_internal.h"
@ -217,7 +218,9 @@ TEST_F(MathFunctionsTest, hex_string) {
}
TEST_F(MathFunctionsTest, unhex) {
doris_udf::FunctionContext* context = new doris_udf::FunctionContext();
MemPool mem_pool;
doris_udf::FunctionContext* context =
doris_udf::FunctionContext::create_test_context(&mem_pool);
EXPECT_EQ(StringVal::null(), MathFunctions::unhex(context, StringVal::null()));