database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](planner) ctas should not change any meta of column in source table (#24767)

Browse Source 
if previous PR #22770. we try to fix incorrect nullable in target table.
However we changed nullable info of column in source table unexpectly
This commit is contained in:
morrySnow
2023-09-22 11:49:38 +08:00
committed by GitHub
parent 8a85a75b8b
commit b5f6ace204
3 changed files with 64 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java
View File

@ -17,6 +17,7 @@
package org.apache.doris.analysis;
import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.ScalarType;
import org.apache.doris.catalog.Type;
import org.apache.doris.common.Config;
@ -82,8 +83,9 @@ public class CreateTableAsSelectStmt extends DdlStmt {
Preconditions.checkArgument(outputs.size() == queryStmt.getResultExprs().size());
for (int i = 0; i < outputs.size(); ++i) {
if (queryStmt.getResultExprs().get(i).getSrcSlotRef() != null) {
queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn()
.setIsAllowNull(outputs.get(i).isNullable());
Column columnCopy = new Column(queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn());
columnCopy.setIsAllowNull(outputs.get(i).isNullable());
queryStmt.getResultExprs().get(i).getSrcSlotRef().getDesc().setColumn(columnCopy);
}
if (Config.enable_date_conversion) {
if (queryStmt.getResultExprs().get(i).getType() == Type.DATE) {

13
regression-test/suites/ddl_p0/test_ctas.groovy
View File

@ -230,16 +230,21 @@ suite("test_ctas") {
sql 'insert into a values(1, \'ww\'), (2, \'zs\');'
sql 'insert into b values(1, 22);'
sql 'create table c properties("replication_num"="1") as select a.id, a.name, b.age from a left join b on a.id = b.id;'
sql 'set enable_nereids_planner=false'
sql 'create table c properties("replication_num"="1") as select b.id, a.name, b.age from a left join b on a.id = b.id;'
String desc = sql 'desc c'
assertTrue(desc.contains('Yes'))
String descC = sql 'desc c'
assertTrue(descC.contains('Yes'))
String descB = sql 'desc b'
assertTrue(descB.contains('No'))
sql '''create table test_date_v2
properties (
"replication_num"="1"
) as select to_date('20250829');
'''
desc = sql 'desc test_date_v2'
String desc = sql 'desc test_date_v2'
assertTrue(desc.contains('Yes'))
} finally {
sql 'drop table a'

51
regression-test/suites/nereids_p0/create_table/test_ctas.groovy
View File

@ -222,5 +222,56 @@ suite("nereids_test_ctas") {
"""
qt_select """select * from ${table2} order by c1;"""
try {
sql "drop table if exists a"
sql "drop table if exists b"
sql "drop table if exists c"
sql "drop table if exists test_date_v2"
sql '''create table a (
id int not null,
name varchar(20) not null
)
distributed by hash(id) buckets 4
properties (
"replication_num"="1"
);
'''
sql '''create table b (
id int not null,
age int not null
)
distributed by hash(id) buckets 4
properties (
"replication_num"="1"
);
'''
sql 'insert into a values(1, \'ww\'), (2, \'zs\');'
sql 'insert into b values(1, 22);'
sql 'set enable_nereids_planner=false'
sql 'create table c properties("replication_num"="1") as select b.id, a.name, b.age from a left join b on a.id = b.id;'
String descC = sql 'desc c'
assertTrue(descC.contains('Yes'))
String descB = sql 'desc b'
assertTrue(descB.contains('No'))
sql '''create table test_date_v2
properties (
"replication_num"="1"
) as select to_date('20250829');
'''
String desc = sql 'desc test_date_v2'
assertTrue(desc.contains('Yes'))
} finally {
sql 'drop table a'
sql 'drop table b'
sql 'drop table c'
sql 'drop table test_date_v2'
}
}