database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](profile) fix possible coredump of rpc verbose profile (#40117)

Browse Source 
## Proposed changes

Issue Number: close #xxx

`_instance_to_rpc_stats_vec` may be updated when sorting in
`ExchangeSinkBuffer<Parent>::update_profile`, which may cause coredump.
This commit is contained in:
TengJianPing
2024-08-29 23:54:52 +08:00
committed by GitHub
parent c50d2ea4e2
commit b86e4e8498
2 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
be/src/pipeline/exec/exchange_sink_buffer.cpp
View File

@ -555,25 +555,29 @@ void ExchangeSinkBuffer<Parent>::update_profile(RuntimeProfile* profile) {
if constexpr (std::is_same_v<ExchangeSinkLocalState, Parent>) {
auto max_count = _state->rpc_verbose_profile_max_instance_count();
if (_state->enable_verbose_profile() && max_count > 0) {
pdqsort(_instance_to_rpc_stats_vec.begin(), _instance_to_rpc_stats_vec.end(),
[](const auto& a, const auto& b) { return a->max_time > b->max_time; });
auto count = std::min((size_t)max_count, _instance_to_rpc_stats_vec.size());
std::vector<RpcInstanceStatistics> tmp_rpc_stats_vec;
for (const auto& stats : _instance_to_rpc_stats_vec) {
tmp_rpc_stats_vec.emplace_back(*stats);
}
pdqsort(tmp_rpc_stats_vec.begin(), tmp_rpc_stats_vec.end(),
[](const auto& a, const auto& b) { return a.max_time > b.max_time; });
auto count = std::min((size_t)max_count, tmp_rpc_stats_vec.size());
int i = 0;
auto* detail_profile = profile->create_child("RpcInstanceDetails", true, true);
for (const auto& stats : _instance_to_rpc_stats_vec) {
if (0 == stats->rpc_count) {
for (const auto& stats : tmp_rpc_stats_vec) {
if (0 == stats.rpc_count) {
continue;
}
std::stringstream out;
out << "Instance " << std::hex << stats->inst_lo_id;
out << "Instance " << std::hex << stats.inst_lo_id;
auto stats_str = fmt::format(
"Count: {}, MaxTime: {}, MinTime: {}, AvgTime: {}, SumTime: {}",
stats->rpc_count, PrettyPrinter::print(stats->max_time, TUnit::TIME_NS),
PrettyPrinter::print(stats->min_time, TUnit::TIME_NS),
PrettyPrinter::print(stats->sum_time / std::max(static_cast<int64_t>(1),
stats->rpc_count),
TUnit::TIME_NS),
PrettyPrinter::print(stats->sum_time, TUnit::TIME_NS));
stats.rpc_count, PrettyPrinter::print(stats.max_time, TUnit::TIME_NS),
PrettyPrinter::print(stats.min_time, TUnit::TIME_NS),
PrettyPrinter::print(
stats.sum_time / std::max(static_cast<int64_t>(1), stats.rpc_count),
TUnit::TIME_NS),
PrettyPrinter::print(stats.sum_time, TUnit::TIME_NS));
detail_profile->add_info_string(out.str(), stats_str);
if (++i == count) {
break;

2
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
View File

@ -712,7 +712,7 @@ public class SessionVariable implements Serializable, Writable {
public boolean enableProfile = false;
@VariableMgr.VarAttr(name = ENABLE_VERBOSE_PROFILE, needForward = true)
public boolean enableVerboseProfile = true;
public boolean enableVerboseProfile = false;
@VariableMgr.VarAttr(name = RPC_VERBOSE_PROFILE_MAX_INSTANCE_COUNT, needForward = true)
public int rpcVerboseProfileMaxInstanceCount = 5;