database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](common) implement the move assignment operator for Status (#23372)

Browse Source
This commit is contained in:
Ashin Gau
2023-08-24 14:41:19 +08:00
committed by GitHub
parent 303d5ac3f7
commit c6ac925f5a
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
be/src/common/status.h
View File

@ -311,7 +311,7 @@ consteval bool capture_stacktrace(int code) {
class Status {
public:
Status() : _code(ErrorCode::OK) {}
Status() : _code(ErrorCode::OK), _err_msg(nullptr) {}
// copy c'tor makes copy of error detail so Status can be returned by value
Status(const Status& rhs) { *this = rhs; }
@ -329,7 +329,13 @@ public:
}
// move assign
Status& operator=(Status&& rhs) noexcept = default;
Status& operator=(Status&& rhs) noexcept {
_code = rhs._code;
if (rhs._err_msg) {
_err_msg = std::move(rhs._err_msg);
}
return *this;
}
Status static create(const TStatus& status) {
return Error<true>(status.status_code,