database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[bugfix](brpc) Should use status to generate protobuf message, because it will encoding Backend Info (#41515) (#41522)

Browse Source 
Should use status to generate protobuf message, because it will encoding
Backend Info

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
This commit is contained in:
yiguolei
2024-10-04 23:03:55 +08:00
committed by GitHub
parent d33a3eb1c5
commit cb24ccc112
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
be/src/service/internal_service.cpp
View File

@ -189,9 +189,11 @@ concept CanCancel = requires(T* response) { response->mutable_status(); };
template <CanCancel T>
void offer_failed(T* response, google::protobuf::Closure* done, const FifoThreadPool& pool) {
brpc::ClosureGuard closure_guard(done);
response->mutable_status()->set_status_code(TStatusCode::CANCELLED);
response->mutable_status()->add_error_msgs("fail to offer request to the work pool, pool=" +
pool.get_info());
// Should use status to generate protobuf message, because it will encoding Backend Info
// into the error message and then we could know which backend's pool is full.
Status st = Status::Error<TStatusCode::CANCELLED>(
"fail to offer request to the work pool, pool={}", pool.get_info());
st.to_protobuf(response->mutable_status());
LOG(WARNING) << "cancelled due to fail to offer request to the work pool, pool="
<< pool.get_info();
}