database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

branch-2.1: [fix](nereids) not rewrite first_value when first_value ignore nulls #45065 (#45236)

Browse Source 
Cherry-picked from #45065

Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
This commit is contained in:
github-actions[bot]
2024-12-11 14:36:48 +08:00
committed by GitHub
parent 44fa86040f
commit cbab6f55c3
3 changed files with 61 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/WindowFunctionChecker.java
View File

@ -37,6 +37,7 @@ import org.apache.doris.nereids.trees.expressions.functions.window.Ntile;
import org.apache.doris.nereids.trees.expressions.functions.window.PercentRank;
import org.apache.doris.nereids.trees.expressions.functions.window.Rank;
import org.apache.doris.nereids.trees.expressions.functions.window.RowNumber;
import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral;
import org.apache.doris.nereids.trees.expressions.literal.Literal;
import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionVisitor;
import org.apache.doris.nereids.util.TypeCoercionUtils;
@ -315,6 +316,10 @@ public class WindowFunctionChecker extends DefaultExpressionVisitor<Expression,
*/
@Override
public FirstOrLastValue visitFirstValue(FirstValue firstValue, Void ctx) {
FirstOrLastValue.checkSecondParameter(firstValue);
if (2 == firstValue.arity() && firstValue.child(1).equals(BooleanLiteral.TRUE)) {
return firstValue;
}
Optional<WindowFrame> windowFrame = windowExpression.getWindowFrame();
if (windowFrame.isPresent()) {
WindowFrame wf = windowFrame.get();
@ -339,6 +344,12 @@ public class WindowFunctionChecker extends DefaultExpressionVisitor<Expression,
return firstValue;
}
@Override
public FirstOrLastValue visitLastValue(LastValue lastValue, Void ctx) {
FirstOrLastValue.checkSecondParameter(lastValue);
return lastValue;
}
/**
* required WindowFrame: (RANGE, UNBOUNDED PRECEDING, CURRENT ROW)
*/

15
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/FirstOrLastValue.java
View File

@ -18,9 +18,11 @@
package org.apache.doris.nereids.trees.expressions.functions.window;
import org.apache.doris.catalog.FunctionSignature;
import org.apache.doris.nereids.exceptions.AnalysisException;
import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.functions.AlwaysNullable;
import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral;
import org.apache.doris.nereids.types.BooleanType;
import org.apache.doris.nereids.types.coercion.AnyDataType;
@ -63,4 +65,17 @@ public abstract class FirstOrLastValue extends WindowFunction
public List<FunctionSignature> getSignatures() {
return SIGNATURES;
}
/**check the second parameter must be true or false*/
public static void checkSecondParameter(FirstOrLastValue firstOrLastValue) {
if (1 == firstOrLastValue.arity()) {
return;
}
if (!BooleanLiteral.TRUE.equals(firstOrLastValue.child(1))
&& !BooleanLiteral.FALSE.equals(firstOrLastValue.child(1))) {
throw new AnalysisException("The second parameter of " + firstOrLastValue.getName()
+ " must be a constant or a constant expression, and the result of "
+ "the calculated constant or constant expression must be true or false.");
}
}
}

35
regression-test/suites/nereids_syntax_p0/window_function.groovy
View File

@ -279,4 +279,39 @@ suite("window_function") {
)t
)a where rn=1
"""
// test first value second param is not constant
test {
sql "select first_value(c1,c1) over() from window_test"
exception "The second parameter of first_value must be a constant or a constant expression, and the result of the calculated constant or constant expression must be true or false."
}
test {
sql "select last_value(c1,c1) over() from window_test"
exception "The second parameter of last_value must be a constant or a constant expression, and the result of the calculated constant or constant expression must be true or false."
}
test {
sql "select first_value(c1,cast('abc' as boolean)) over() from window_test"
exception "The second parameter of first_value must be a constant or a constant expression, and the result of the calculated constant or constant expression must be true or false."
}
test {
sql "select first_value(c1,'') over() from window_test"
exception "The second parameter of first_value must be a constant or a constant expression, and the result of the calculated constant or constant expression must be true or false."
}
test {
sql "select last_value(c1,'345_a') over() from window_test"
exception "The second parameter of last_value must be a constant or a constant expression, and the result of the calculated constant or constant expression must be true or false."
}
sql "select last_value(c1,cast('67' as boolean)) over() from window_test"
sql "select first_value(c1,cast(56 as boolean)) over() from window_test"
sql "select last_value(c1,cast(56 as boolean)) over() from window_test"
sql "select first_value(c1,cast('true' as boolean)) over() from window_test"
sql "select last_value(c1,cast('false' as boolean)) over() from window_test"
sql "select first_value(c1,cast('1' as boolean)) over() from window_test"
sql "select last_value(c1,cast('0' as boolean)) over() from window_test"
sql "select first_value(c1,true) over() from window_test"
sql "select last_value(c1,false) over() from window_test"
sql "select first_value(c1,1) over() from window_test"
sql "select last_value(c1,0) over() from window_test"
}