database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Revert "[fix](csv-reader) fix column split error when there is escape character (#34364)"

Browse Source 
This reverts commit 971e10a9db782c9986b20e1209468e4d7aeedf71.
This commit is contained in:
yiguolei
2024-05-07 13:36:11 +08:00
parent 4ecc3edc21
commit d127d67ebe
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.cpp
View File

@ -143,12 +143,13 @@ void EncloseCsvLineReaderContext::_on_normal(const uint8_t* start, size_t& len)
}
void EncloseCsvLineReaderContext::_on_pre_match_enclose(const uint8_t* start, size_t& len) {
bool should_escape = false;
do {
do {
if (start[_idx] == _escape) [[unlikely]] {
_should_escape = !_should_escape;
} else if (_should_escape) [[unlikely]] {
_should_escape = false;
should_escape = !should_escape;
} else if (should_escape) [[unlikely]] {
should_escape = false;
} else if (start[_idx] == _enclose) [[unlikely]] {
_state.forward_to(ReaderState::MATCH_ENCLOSE);
++_idx;

2
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h
View File

@ -135,7 +135,6 @@ public:
inline void refresh_impl() {
_idx = 0;
_should_escape = false;
_result = nullptr;
_column_sep_positions.clear();
_state.reset();
@ -169,7 +168,6 @@ private:
const size_t _column_sep_len;
size_t _idx = 0;
bool _should_escape = false;
const std::string _column_sep;
std::vector<size_t> _column_sep_positions;