database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](planner)infer predicate rule infer binary pridicate when two slot do not equal by mistake (#10356)

Browse Source 
infer predicate rule infer binary predicate when two slot do not equal by mistake
This commit is contained in:
morrySnow
2022-06-24 08:56:12 +08:00
committed by GitHub
parent f06a06d623
commit d5be190cf9
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fe/fe-core/src/main/java/org/apache/doris/rewrite/InferFiltersRule.java
View File

@ -183,7 +183,8 @@ public class InferFiltersRule implements ExprRewriteRule {
}
analyzer.registerGlobalSlotToLiteralDeDuplication(pair);
}
} else if (conjunct.getChild(0).unwrapSlotRef() instanceof SlotRef
} else if (((BinaryPredicate) conjunct).getOp().isEquivalence()
&& conjunct.getChild(0).unwrapSlotRef() instanceof SlotRef
&& conjunct.getChild(1).unwrapSlotRef() instanceof SlotRef) {
Pair<Expr, Expr> pair = new Pair<>(conjunct.getChild(0).unwrapSlotRef(),
conjunct.getChild(1).unwrapSlotRef());

19
fe/fe-core/src/test/java/org/apache/doris/rewrite/InferFiltersRuleTest.java
View File

@ -77,7 +77,6 @@ public class InferFiltersRuleTest {
}
@Test
//default enableInferPredicate = true;
public void testRewritten() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
@ -87,6 +86,16 @@ public class InferFiltersRuleTest {
Assert.assertTrue(planString.contains("`tb2`.`k1` = 1"));
}
@Test
public void testUnequalSlotPredicate() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
Assert.assertTrue(sessionVariable.isEnableInferPredicate());
String query = "select * from tb1, tb2 where tb1.k1 = 1 and tb1.k1 > tb2.k1";
String planString = dorisAssert.query(query).explainQuery();
Assert.assertFalse(planString.contains("`tb2`.`k1` = 1"));
}
@Test
public void testOn3TablesBothInnerJoinRewritten() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
@ -99,7 +108,6 @@ public class InferFiltersRuleTest {
}
@Test
//set enableInferPredicate = true;
public void testOn2TablesLeftSemiJoinEqLiteralAt2nd() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
@ -110,7 +118,6 @@ public class InferFiltersRuleTest {
}
@Test
//set enableInferPredicate = true;
public void testOn2TablesLeftSemiJoinEqLiteralAt1st() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
@ -121,7 +128,6 @@ public class InferFiltersRuleTest {
}
@Test
//set enableInferPredicate = true;
public void testOn2TablesLeftAntiJoinEqLiteralAt2nd() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
@ -142,7 +148,6 @@ public class InferFiltersRuleTest {
}
@Test
//set enableInferPredicate = true;
public void testOn3Tables1stInner2ndRightJoinEqLiteralAt2nd() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
@ -197,7 +202,6 @@ public class InferFiltersRuleTest {
}
@Test
//set enableInferPredicate = true;
public void testWhere3TablesInnerJoinRewritten() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
@ -220,7 +224,6 @@ public class InferFiltersRuleTest {
}
@Test
//set enableInferPredicate = true;
public void testWhere3Tables1stInner2ndLeftJoinEqLiteralAt3rd() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
@ -232,7 +235,6 @@ public class InferFiltersRuleTest {
}
@Test
//set enableInferPredicate = true;
public void testWhere3Tables1stInner2ndLeftJoinEqLiteralAt2nd() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);
@ -244,7 +246,6 @@ public class InferFiltersRuleTest {
}
@Test
//set enableInferPredicate = true;
public void testWhere3Tables1stInner2ndRightJoinEqLiteralAt2nd() throws Exception {
SessionVariable sessionVariable = dorisAssert.getSessionVariable();
sessionVariable.setEnableInferPredicate(true);