database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Enhancement](optimize) optimize for function multiply on decimalv2 (#13049)

Browse Source 
optimize for function multiply on decimalv2
This commit is contained in:
Pxl
2022-10-04 16:07:18 +08:00
committed by GitHub
parent 0dd2fb758c
commit db89b0b703
2 changed files with 33 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
be/src/vec/functions/function_binary_arithmetic.h
View File

@ -20,6 +20,9 @@
#pragma once
#include <type_traits>
#include "runtime/decimalv2_value.h"
#include "vec/columns/column_const.h"
#include "vec/columns/column_decimal.h"
#include "vec/columns/column_nullable.h"
@ -241,9 +244,13 @@ struct DecimalBinaryOperation {
}
}
/// default: use it if no return before
for (size_t i = 0; i < size; ++i) {
c[i] = apply(a[i], b[i]);
if constexpr (OpTraits::is_multiply && std::is_same_v<A, Decimal128> &&
std::is_same_v<B, Decimal128>) {
Op::vector_vector(a, b, c);
} else {
for (size_t i = 0; i < size; i++) {
c[i] = apply(a[i], b[i]);
}
}
}

24
be/src/vec/functions/multiply.cpp
View File

@ -18,6 +18,8 @@
// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/Multiply.cpp
// and modified by Doris
#include "runtime/decimalv2_value.h"
#include "vec/columns/column_decimal.h"
#include "vec/common/arithmetic_overflow.h"
#include "vec/functions/function_binary_arithmetic.h"
#include "vec/functions/simple_function_factory.h"
@ -35,9 +37,29 @@ struct MultiplyImpl {
}
template <typename Result = DecimalV2Value>
static inline DecimalV2Value apply(DecimalV2Value a, DecimalV2Value b) {
static inline DecimalV2Value apply(const DecimalV2Value& a, const DecimalV2Value& b) {
return a * b;
}
static void vector_vector(const ColumnDecimal128::Container& a,
const ColumnDecimal128::Container& b,
ColumnDecimal128::Container& c) {
size_t size = c.size();
int8 sgn[size];
for (int i = 0; i < size; i++) {
sgn[i] = ((DecimalV2Value(a[i]).value() >= 0) == (DecimalV2Value(b[i]).value() >= 0))
? 1
: -1;
}
for (int i = 0; i < size; i++) {
c[i] = (DecimalV2Value(a[i]).value() * DecimalV2Value(b[i]).value() - sgn[i]) /
DecimalV2Value::ONE_BILLION +
sgn[i];
}
}
/// Apply operation and check overflow. It's used for Deciamal operations. @returns true if overflowed, false otherwise.
template <typename Result = ResultType>
static inline bool apply(A a, B b, Result& c) {