database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug](date) fix BE crash if month_floor 's argument is null (#16281)

Browse Source
This commit is contained in:
Gabriel
2023-02-01 12:25:57 +08:00
committed by GitHub
parent 95d7c2de26
commit dbd1dfb64c
3 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
be/src/vec/functions/function_datetime_floor_ceil.cpp
View File

@ -434,13 +434,20 @@ struct TimeRound {
res = origin_date;
auto ts2 = binary_cast<NativeType, DateValueType>(date);
auto& ts1 = (DateValueType&)(res);
if (!ts2.is_valid_date() || !ts1.is_valid_date()) {
is_null = true;
return;
}
TimeRound<Impl>::template time_round<NativeType, DateValueType>(ts2, period, ts1, is_null);
}
template <typename NativeType, typename DateValueType>
static void time_round(NativeType date, Int32 period, NativeType& res, UInt8& is_null) {
auto ts2 = binary_cast<NativeType, DateValueType>(date);
if (!ts2.is_valid_date()) {
is_null = true;
return;
}
auto& ts1 = (DateValueType&)(res);
if constexpr (Impl::Unit != WEEK) {
ts1.from_olap_datetime(FIRST_DAY);

15
regression-test/data/nereids_function_p0/scalar_function/L-Q.out
View File

@ -1304,6 +1304,21 @@ dc5f80c371451aa4fc81c930adc64f60
2012-03-01T00:00
2012-03-01T00:00
-- !sql --
\N
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
2012-03-01T00:00
-- !sql --
\N
2012-03-01

2
regression-test/suites/nereids_function_p0/scalar_function/L-Q.groovy
View File

@ -150,7 +150,7 @@ suite("nereids_scalar_fn_3") {
qt_sql "select month_ceil(kdtmv2s1, kint, kdtmv2s1) from fn_test order by kdtmv2s1, kint, kdtmv2s1"
qt_sql "select month_ceil(kdtv2, kint, kdtv2) from fn_test order by kdtv2, kint, kdtv2"
// core
// qt_sql "select month_floor(kdtm) from fn_test order by kdtm"
qt_sql "select month_floor(kdtm) from fn_test order by kdtm"
qt_sql "select month_floor(kdtmv2s1) from fn_test order by kdtmv2s1"
qt_sql "select month_floor(kdtv2) from fn_test order by kdtv2"
qt_sql "select month_floor(kdtm, kdtm) from fn_test order by kdtm, kdtm"