database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](nereids)use same decimalv3 type for params and return types (#20101)

Browse Source
This commit is contained in:
starocean999
2023-05-26 20:15:51 +08:00
committed by GitHub
parent 9458a24cd7
commit dcdc81844f
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fe/fe-core/src/main/java/org/apache/doris/analysis/ArithmeticExpr.java
View File

@ -512,8 +512,16 @@ public class ArithmeticExpr extends Expr {
}
castChild(ScalarType.createDecimalV3Type(precision, targetScale), 0);
} else if (op == Operator.MOD) {
castChild(type, 0);
castChild(type, 1);
// TODO use max int part + max scale of two operands as result type
// because BE require the result and operands types are the exact the same decimalv3 type
precision = Math.max(widthOfIntPart1, widthOfIntPart2) + scale;
if (precision > ScalarType.MAX_DECIMAL128_PRECISION) {
type = castBinaryOp(Type.DOUBLE);
} else {
type = ScalarType.createDecimalV3Type(precision, scale);
castChild(type, 0);
castChild(type, 1);
}
}
break;
case INT_DIVIDE:

4
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Mod.java
View File

@ -44,8 +44,10 @@ public class Mod extends BinaryArithmetic implements AlwaysNullable {
@Override
public DecimalV3Type getDataTypeForDecimalV3(DecimalV3Type t1, DecimalV3Type t2) {
// TODO use max int part + max scale of two operands as result type
// because BE require the result and operands types are the exact the same decimalv3 type
int scale = Math.max(t1.getScale(), t2.getScale());
int precision = t2.getRange() + scale;
int precision = Math.max(t1.getRange(), t2.getRange()) + scale;
return DecimalV3Type.createDecimalV3Type(precision, scale);
}