database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[bug] Make compaction metrics value is right (#3903)

Browse Source 
Now _input_rowsets will be cleared when calling gc_used_rowsets().
After that, the metrics is not right upon be calculated.
This commit is contained in:
lichaoyong
2020-06-19 11:22:06 +08:00
committed by GitHub
parent 1d9fa5071d
commit e0461cc7f4
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
be/src/olap/base_compaction.cpp
View File

@ -51,13 +51,14 @@ OLAPStatus BaseCompaction::compact() {
// 3. set state to success
_state = CompactionState::SUCCESS;
// 4. garbage collect input rowsets after base compaction
RETURN_NOT_OK(gc_unused_rowsets());
TRACE("unused rowsets have been moved to GC queue");
// 5. add metric to base compaction
// 4. add metric to base compaction
DorisMetrics::instance()->base_compaction_deltas_total.increment(_input_rowsets.size());
DorisMetrics::instance()->base_compaction_bytes_total.increment(_input_rowsets_size);
TRACE("save base compaction metrics");
// 5. garbage collect input rowsets after base compaction
RETURN_NOT_OK(gc_unused_rowsets());
TRACE("unused rowsets have been moved to GC queue");
return OLAP_SUCCESS;
}

11
be/src/olap/cumulative_compaction.cpp
View File

@ -60,13 +60,14 @@ OLAPStatus CumulativeCompaction::compact() {
// 5. set cumulative point
_tablet->set_cumulative_layer_point(_input_rowsets.back()->end_version() + 1);
// 6. garbage collect input rowsets after cumulative compaction
RETURN_NOT_OK(gc_unused_rowsets());
TRACE("unused rowsets have been moved to GC queue");
// 7. add metric to cumulative compaction
// 6. add metric to cumulative compaction
DorisMetrics::instance()->cumulative_compaction_deltas_total.increment(_input_rowsets.size());
DorisMetrics::instance()->cumulative_compaction_bytes_total.increment(_input_rowsets_size);
TRACE("save cumulative compaction metrics");
// 7. garbage collect input rowsets after cumulative compaction
RETURN_NOT_OK(gc_unused_rowsets());
TRACE("unused rowsets have been moved to GC queue");
return OLAP_SUCCESS;
}