database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[bugfix](compaction) remove useless check (#17804)

Browse Source 
transient size may not equal to candidate_rowset size.
For example, one rowset has many segment, but size is smaller then
promotion size, this rowset will break pick rowset loop cause compaction
score is enough but will be filtered in level_size check, this will make
 transient size not equal to candidate size.
This commit is contained in:
yixiutt
2023-03-16 15:23:49 +08:00
committed by GitHub
parent caed2155f5
commit ea943415a0
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
be/src/olap/cumulative_compaction.cpp
View File

@ -114,7 +114,7 @@ Status CumulativeCompaction::pick_rowsets_to_compact() {
}
size_t compaction_score = 0;
int transient_size = _tablet->cumulative_compaction_policy()->pick_input_rowsets(
_tablet->cumulative_compaction_policy()->pick_input_rowsets(
_tablet.get(), candidate_rowsets, config::cumulative_compaction_max_deltas,
config::cumulative_compaction_min_deltas, &_input_rowsets, &_last_delete_version,
&compaction_score);
@ -146,9 +146,6 @@ Status CumulativeCompaction::pick_rowsets_to_compact() {
if (cumu_interval > interval_threshold && base_interval > interval_threshold) {
// before increasing cumulative point, we should make sure all rowsets are non-overlapping.
// if at least one rowset is overlapping, we should compact them first.
CHECK(candidate_rowsets.size() == transient_size)
<< "tablet: " << _tablet->full_name() << ", " << candidate_rowsets.size()
<< " vs. " << transient_size;
for (auto& rs : candidate_rowsets) {
if (rs->rowset_meta()->is_segments_overlapping()) {
_input_rowsets = candidate_rowsets;