database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix bug that schema change does not set null value correctly (#524)

Browse Source
This commit is contained in:
Mingyu Chen
2019-01-10 18:35:03 +08:00
committed by lichaoyong
parent 0b50617542
commit eae755f833
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
be/src/olap/column_reader.cpp
View File

@ -641,7 +641,6 @@ ColumnReader* ColumnReader::create(uint32_t column_id,
field_info.default_value, field_info.type, field_info.length);
}
} else if (field_info.is_allow_null) {
LOG(WARNING) << "create NullValueReader: " << field_info.name;
return new(std::nothrow) NullValueReader(column_id, column_unique_id);
} else {
OLAP_LOG_WARNING("not null field has no default value");

2
be/src/olap/schema_change.cpp
View File

@ -2358,7 +2358,7 @@ OLAPStatus SchemaChangeHandler::_init_column_mapping(ColumnMapping* column_mappi
return OLAP_ERR_MALLOC_ERROR;
}
if (true == column_schema.is_allow_null && value.length() == 0) {
if (column_schema.is_allow_null && !column_schema.has_default_value) {
column_mapping->default_value->set_null();
} else {
column_mapping->default_value->from_string(value);