database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](scan) fix ignore expr exec when _non_predicate_columns is empty (#33934)

Browse Source 
fix ignore expr exec when _non_predicate_columns is empty
This commit is contained in:
Mryange
2024-04-25 14:06:15 +08:00
committed by yiguolei
parent c2e3defe56
commit f34fe46bfa
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
be/src/olap/rowset/segment_v2/segment_iterator.cpp
View File

@ -1956,14 +1956,16 @@ void SegmentIterator::_replace_version_col(size_t num_rows) {
uint16_t SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_idx,
uint16_t selected_size) {
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
if (_is_need_vec_eval) {
_is_need_vec_eval = false;
for (const auto& pred : _pre_eval_block_predicate) {
_is_need_vec_eval |= (!pred->always_true());
bool all_pred_always_true = true;
for (const auto& pred : _pre_eval_block_predicate) {
if (!pred->always_true()) {
all_pred_always_true = false;
break;
}
}
if (!_is_need_vec_eval) {
for (uint32_t i = 0; i < selected_size; ++i) {
//If all predicates are always_true, then return directly.
if (all_pred_always_true || !_is_need_vec_eval) {
for (uint16_t i = 0; i < selected_size; ++i) {
sel_rowid_idx[i] = i;
}
return selected_size;
@ -2247,6 +2249,9 @@ Status SegmentIterator::_next_batch_internal(vectorized::Block* block) {
}
if (!_is_need_vec_eval && !_is_need_short_eval && !_is_need_expr_eval) {
if (_non_predicate_columns.empty()) {
return Status::InternalError("_non_predicate_columns is empty");
}
RETURN_IF_ERROR(_convert_to_expected_type(_first_read_column_ids));
RETURN_IF_ERROR(_convert_to_expected_type(_non_predicate_columns));
_output_non_pred_columns(block);