[branch-2.1](memory) Fix EngineStorageMigrationTask MemTracker attach thread (#33509)

This commit is contained in:
Xinyi Zou
2024-04-11 08:35:13 +08:00
committed by GitHub
parent 6bef95eb4f
commit f3a60374b5
4 changed files with 6 additions and 1 deletions

View File

@ -1735,6 +1735,7 @@ void storage_medium_migrate_callback(StorageEngine& engine, const TAgentTaskRequ
auto status = check_migrate_request(engine, storage_medium_migrate_req, tablet, &dest_store);
if (status.ok()) {
EngineStorageMigrationTask engine_task(tablet, dest_store);
SCOPED_ATTACH_TASK(engine_task.mem_tracker());
status = engine_task.execute();
}
// fe should ignore this err

View File

@ -224,6 +224,7 @@ Status TabletMigrationAction::_execute_tablet_migration(TabletSharedPtr tablet,
int32_t schema_hash = tablet->schema_hash();
string dest_disk = dest_store->path();
EngineStorageMigrationTask engine_task(tablet, dest_store);
SCOPED_ATTACH_TASK(engine_task.mem_tracker());
Status res = engine_task.execute();
if (!res.ok()) {
LOG(WARNING) << "tablet migrate failed. tablet_id=" << tablet_id

View File

@ -63,7 +63,8 @@ public:
private:
SnapshotManager() : _snapshot_base_id(0) {
_mem_tracker = MemTrackerLimiter::create_shared(MemTrackerLimiter::Type::OTHER, "SnapshotManager");
_mem_tracker =
MemTrackerLimiter::create_shared(MemTrackerLimiter::Type::OTHER, "SnapshotManager");
}
Status _calc_snapshot_id_path(const TabletSharedPtr& tablet, int64_t timeout_s,

View File

@ -53,6 +53,8 @@ EngineStorageMigrationTask::EngineStorageMigrationTask(const TabletSharedPtr& ta
DataDir* dest_store)
: _tablet(tablet), _dest_store(dest_store) {
_task_start_time = time(nullptr);
_mem_tracker = MemTrackerLimiter::create_shared(MemTrackerLimiter::Type::OTHER,
"EngineStorageMigrationTask");
}
Status EngineStorageMigrationTask::execute() {