database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug](storage) add lock on base tablet when create_tablet #21915

Browse Source
This commit is contained in:
Pxl
2023-07-19 00:47:19 +08:00
committed by GitHub
parent fff1983f40
commit f87fad97e1
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
be/src/olap/tablet_manager.cpp
View File

@ -29,6 +29,7 @@
#include <algorithm>
#include <list>
#include <mutex>
#include <ostream>
// IWYU pragma: no_include <opentelemetry/common/threadlocal.h>
@ -261,7 +262,12 @@ Status TabletManager::create_tablet(const TCreateTabletReq& request, std::vector
// If the CreateTabletReq has base_tablet_id then it is a alter-tablet request
if (request.__isset.base_tablet_id && request.base_tablet_id > 0) {
is_schema_change = true;
base_tablet = _get_tablet_unlocked(request.base_tablet_id);
// if base_tablet_id's lock diffrent with new_tablet_id, we need lock it.
if ((_tablets_shards_mask & request.base_tablet_id) != (_tablets_shards_mask & tablet_id)) {
base_tablet = get_tablet(request.base_tablet_id);
} else {
base_tablet = _get_tablet_unlocked(request.base_tablet_id);
}
if (base_tablet == nullptr) {
DorisMetrics::instance()->create_tablet_requests_failed->increment(1);
return Status::Error<TABLE_CREATE_META_ERROR>(