database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](emptynode)fix empty node bug in vec engine (#12258)

Browse Source 
* [fix](emptynode)fix empty node bug in vec engine

* update fe ut
This commit is contained in:
starocean999
2022-09-01 18:52:10 +08:00
committed by GitHub
parent ad8e2f4749
commit f8eb480bec
4 changed files with 88 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
View File

@ -182,7 +182,7 @@ public class SingleNodePlanner {
private PlanNode createEmptyNode(PlanNode inputPlan, QueryStmt stmt, Analyzer analyzer) throws UserException {
ArrayList<TupleId> tupleIds = Lists.newArrayList();
if (inputPlan != null) {
tupleIds = inputPlan.tupleIds;
tupleIds.addAll(inputPlan.getOutputTupleIds());
}
if (tupleIds.isEmpty()) {
// Constant selects do not have materialized tuples at this stage.

2
fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
View File

@ -1923,7 +1923,7 @@ public class QueryPlanTest extends TestWithFeService {
+ " on t1.k1 = a.x where 1 = 0;";
String explainStr = getSQLPlanOrErrorMsg(sql, true);
Assert.assertTrue(UtFrameUtils.checkPlanResultContainsNode(explainStr, 4, "EMPTYSET"));
Assert.assertTrue(explainStr.contains("tuple ids: 0 1 4"));
Assert.assertTrue(explainStr.contains("tuple ids: 5"));
}
@Ignore

6
regression-test/data/correctness_p0/test_outer_join_with_empty_node.out Normal file
View File

@ -0,0 +1,6 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !select --
-- !select --
1 1 1

80
regression-test/suites/correctness_p0/test_outer_join_with_empty_node.groovy Normal file
View File

@ -0,0 +1,80 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
suite("test_outer_join_with_empty_node") {
sql """
drop table if exists t1;
"""
sql """
drop table if exists t2;
"""
sql """
CREATE TABLE `t1` (
`k1` int(11) NULL COMMENT "",
`k2` int(11) NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(`k1`, `k2`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`k1`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"in_memory" = "false",
"storage_format" = "V2"
);
"""
sql """
CREATE TABLE `t2` (
`j1` int(11) NULL COMMENT "",
`j2` int(11) NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(`j1`, `j2`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`j1`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"in_memory" = "false",
"storage_format" = "V2"
);
"""
sql """
insert into t1 values(1, 1);
"""
sql """
insert into t2 values(1, 1);
"""
qt_select """
select * from t1 left join (select max(j1) over() as x from t2)a on t1.k1=a.x where 1=0;
"""
qt_select """
select * from t1 left join (select max(j1) over() as x from t2)a on t1.k1=a.x where 1=1;
"""
sql """
drop table if exists t1;
"""
sql """
drop table if exists t2;
"""
}