database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[enhancement](planner) delete support between predicate (#17892)

Browse Source
This commit is contained in:
morrySnow
2023-03-23 13:24:32 +08:00
committed by GitHub
parent 0bb04c08aa
commit fadf3b906d
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fe/fe-core/src/main/java/org/apache/doris/analysis/DeleteStmt.java
View File

@ -33,9 +33,13 @@ import org.apache.doris.common.util.Util;
import org.apache.doris.mysql.privilege.PrivPredicate;
import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.SessionVariable;
import org.apache.doris.rewrite.BetweenToCompoundRule;
import org.apache.doris.rewrite.ExprRewriteRule;
import org.apache.doris.rewrite.ExprRewriter;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Joiner;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Lists;
import java.util.LinkedList;
@ -43,11 +47,15 @@ import java.util.List;
public class DeleteStmt extends DdlStmt {
private static final List<ExprRewriteRule> EXPR_NORMALIZE_RULES = ImmutableList.of(
BetweenToCompoundRule.INSTANCE
);
private TableRef targetTableRef;
private TableName tableName;
private final PartitionNames partitionNames;
private final FromClause fromClause;
private final Expr wherePredicate;
private Expr wherePredicate;
private final List<Predicate> deleteConditions = new LinkedList<>();
@ -108,6 +116,8 @@ public class DeleteStmt extends DdlStmt {
// analyze predicate
if (fromClause == null) {
ExprRewriter exprRewriter = new ExprRewriter(EXPR_NORMALIZE_RULES);
wherePredicate = exprRewriter.rewrite(wherePredicate, analyzer);
analyzePredicate(wherePredicate);
} else {
constructInsertStmt();

2
regression-test/suites/delete_p0/test_delete_where_in.groovy
View File

@ -94,6 +94,8 @@ suite("test_delete_where_in", "delete_p0") {
def count_5= qt_sql """select count(*) from ${tb_name}"""
logger.info("delete_5 : ${count_5}")
sql """DELETE FROM ${tb_name} WHERE k5 BETWEEN 20000 AND 50000"""
//drop table
qt_sql """truncate table ${tb_name}"""
qt_sql """drop table ${tb_name}"""