database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug](runtime-filter) fix brpc ctrl use after free (#37223)

Browse Source 
part of #35186
This commit is contained in:
Pxl
2024-07-03 21:01:50 +08:00
committed by GitHub
parent 97945af947
commit ffc57c9ef4
1 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
be/src/runtime/runtime_filter_mgr.cpp
View File

@ -346,23 +346,22 @@ Status RuntimeFilterMergeControllerEntity::send_filter_size(const PSendFilterSiz
for (auto addr : cnt_val->source_addrs) {
std::shared_ptr<PBackendService_Stub> stub(
ExecEnv::GetInstance()->brpc_internal_client_cache()->get_client(addr));
AsyncRPCContext<PSyncFilterSizeRequest, PSyncFilterSizeResponse> ctx;
auto* pquery_id = ctx.request.mutable_query_id();
auto closure = AutoReleaseClosure<PSyncFilterSizeRequest,
DummyBrpcCallback<PSyncFilterSizeResponse>>::
create_unique(std::make_shared<PSyncFilterSizeRequest>(),
DummyBrpcCallback<PSyncFilterSizeResponse>::create_shared());
auto* pquery_id = closure->request_->mutable_query_id();
pquery_id->set_hi(_state->query_id.hi());
pquery_id->set_lo(_state->query_id.lo());
ctx.request.set_filter_id(filter_id);
ctx.request.set_filter_size(cnt_val->global_size);
closure->request_->set_filter_id(filter_id);
closure->request_->set_filter_size(cnt_val->global_size);
stub->sync_filter_size(&ctx.cntl, &ctx.request, &ctx.response, brpc::DoNothing());
brpc::Join(ctx.cntl.call_id());
if (auto status = Status::create(ctx.response.status()); !status) {
return status;
}
if (ctx.cntl.Failed()) {
ExecEnv::GetInstance()->brpc_internal_client_cache()->erase(ctx.cntl.remote_side());
return Status::InternalError(ctx.cntl.ErrorText());
}
stub->sync_filter_size(closure->cntl_.get(), closure->request_.get(),
closure->response_.get(), brpc::DoNothing());
closure.release();
}
}
return Status::OK();