database/openGauss-server
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

!1216 Fix issue: handle combined scenario of 'order' and '*' in single query index advisor

Browse Source 
Merge pull request !1216 from liuly/master
This commit is contained in:
opengauss-bot
2021-08-11 06:47:23 +00:00
committed by Gitee
parent baa862ca98 d723f89f73
commit 4515c71e9d
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/gausskernel/dbmind/kernel/index_advisor.cpp
View File

@ -1467,6 +1467,27 @@ char *parse_group_clause(List *group_clause, List *target_list)
return NULL;
}
bool has_star(List *targetList)
{
ListCell* target_cell = NULL;
foreach (target_cell, targetList) {
ResTarget* restarget = (ResTarget *)lfirst(target_cell);
if (nodeTag((Node *)restarget->val) == T_ColumnRef) {
ColumnRef* cref = NULL;
cref = (ColumnRef *)restarget->val;
ListCell* field = NULL;
foreach (field, cref->fields) {
if (nodeTag((Node *)lfirst(field)) == T_A_Star) {
return true;
}
}
}
}
return false;
}
char *parse_order_clause(List *order_clause, List *target_list)
{
if (order_clause == NULL)
@ -1482,6 +1503,9 @@ char *parse_order_clause(List *order_clause, List *target_list)
SortByDir dir = ((SortBy *)(lfirst(order_item)))->sortby_dir;
if (nodeTag(node) == T_A_Const) {
if (has_star(target_list)) {
return NULL;
}
node = transform_group_order_node(node, target_list);
}
if (nodeTag(node) != T_ColumnRef)