database/tidb
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

infoschema: use ListTablesWithSpecialAttribute instead of SchemaTableInfos (#55686)

Browse Source 
* infoschema: use `ListTablesWithSpecialAttribute` instead of `SchemaTableInfos`

* revert

* refactor
This commit is contained in:
CbcWestwolf
2024-08-29 11:28:32 +08:00
committed by GitHub
parent f2856e3521
commit 47ca7bec6b
1 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/server/handler/tikvhandler/tikv_handler.go
View File

@ -637,28 +637,23 @@ func (h FlashReplicaHandler) ServeHTTP(w http.ResponseWriter, req *http.Request)
return
}
replicaInfos := make([]*TableFlashReplicaInfo, 0)
allDBs := schema.AllSchemaNames()
for _, db := range allDBs {
tbls, err := schema.SchemaTableInfos(context.Background(), db)
if err != nil {
handler.WriteError(w, err)
return
}
for _, tbl := range tbls {
replicaInfos = h.getTiFlashReplicaInfo(tbl, replicaInfos)
schemas := schema.ListTablesWithSpecialAttribute(infoschema.TiFlashAttribute)
for _, schema := range schemas {
for _, tbl := range schema.TableInfos {
replicaInfos = appendTiFlashReplicaInfo(replicaInfos, tbl)
}
}
dropedOrTruncateReplicaInfos, err := h.getDropOrTruncateTableTiflash(schema)
droppedOrTruncateReplicaInfos, err := h.getDropOrTruncateTableTiflash(schema)
if err != nil {
handler.WriteError(w, err)
return
}
replicaInfos = append(replicaInfos, dropedOrTruncateReplicaInfos...)
replicaInfos = append(replicaInfos, droppedOrTruncateReplicaInfos...)
handler.WriteData(w, replicaInfos)
}
func (FlashReplicaHandler) getTiFlashReplicaInfo(tblInfo *model.TableInfo, replicaInfos []*TableFlashReplicaInfo) []*TableFlashReplicaInfo {
func appendTiFlashReplicaInfo(replicaInfos []*TableFlashReplicaInfo, tblInfo *model.TableInfo) []*TableFlashReplicaInfo {
if tblInfo.TiFlashReplica == nil {
return replicaInfos
}
@ -718,7 +713,7 @@ func (h FlashReplicaHandler) getDropOrTruncateTableTiflash(currentSchema infosch
return false, nil
}
uniqueIDMap[tblInfo.ID] = struct{}{}
replicaInfos = h.getTiFlashReplicaInfo(tblInfo, replicaInfos)
replicaInfos = appendTiFlashReplicaInfo(replicaInfos, tblInfo)
return false, nil
}
dom := domain.GetDomain(s)