database/tidb
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ddl/ingest: close writer before engine (#54569)

Browse Source 
close pingcap/tidb#54568
This commit is contained in:
lance6716
2024-07-13 12:44:57 +08:00
committed by GitHub
parent 5b5915bd0b
commit 73472c2f3f
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/ddl/ingest/engine.go
View File

@ -110,6 +110,12 @@ func (ei *engineInfo) Clean() {
if ei.openedEngine == nil {
return
}
err := ei.closeWriters()
if err != nil {
logutil.Logger(ei.ctx).Error(LitErrCloseWriterErr, zap.Error(err),
zap.Int64("job ID", ei.jobID), zap.Int64("index ID", ei.indexID))
}
indexEngine := ei.openedEngine
closedEngine, err := indexEngine.Close(ei.ctx)
if err != nil {
@ -118,11 +124,6 @@ func (ei *engineInfo) Clean() {
return
}
ei.openedEngine = nil
err = ei.closeWriters()
if err != nil {
logutil.Logger(ei.ctx).Error(LitErrCloseWriterErr, zap.Error(err),
zap.Int64("job ID", ei.jobID), zap.Int64("index ID", ei.indexID))
}
// Here the local intermediate files will be removed.
err = closedEngine.Cleanup(ei.ctx)
if err != nil {