database/tidb
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sessionctx: fix TiDBGOGCTunerThreshold failing to ParseFloat (#38774)

Browse Source 
close pingcap/tidb#38778
This commit is contained in:
Weizhen Wang
2022-11-01 14:25:59 +08:00
committed by GitHub
parent 7e4d7598be
commit cc2a0388b0
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sessionctx/variable/sysvar.go
View File

@ -738,10 +738,7 @@ var defaultSysVars = []*SysVar{
return strconv.FormatFloat(GOGCTunerThreshold.Load(), 'f', -1, 64), nil
},
Validation: func(s *SessionVars, normalizedValue string, originalValue string, scope ScopeFlag) (string, error) {
floatValue, err := strconv.ParseFloat(normalizedValue, 64)
if err != nil {
return "", err
}
floatValue := tidbOptFloat64(normalizedValue, DefTiDBGOGCTunerThreshold)
globalMemoryLimitTuner := gctuner.GlobalMemoryLimitTuner.GetPercentage()
if floatValue < 0 && floatValue > 0.9 {
return "", ErrWrongValueForVar.GenWithStackByArgs(TiDBGOGCTunerThreshold, normalizedValue)
@ -752,10 +749,7 @@ var defaultSysVars = []*SysVar{
return strconv.FormatFloat(floatValue, 'f', -1, 64), nil
},
SetGlobal: func(_ context.Context, s *SessionVars, val string) error {
factor, err := strconv.ParseFloat(val, 64)
if err != nil {
return err
}
factor := tidbOptFloat64(val, DefTiDBGOGCTunerThreshold)
GOGCTunerThreshold.Store(factor)
memTotal := memory.ServerMemoryLimit.Load()
threshold := float64(memTotal) * factor