database/tidb
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

expression: Add cast as json push down support for tiflash (#48550)

Browse Source 
close pingcap/tidb#48551
This commit is contained in:
SeaRise
2023-11-28 09:08:46 +08:00
committed by GitHub
parent ccbd1b5749
commit d0feede759
2 changed files with 41 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
pkg/expression/expr_to_pb_test.go
View File

@ -1291,6 +1291,44 @@ func TestExprPushDownToFlash(t *testing.T) {
require.NoError(t, err)
exprs = append(exprs, function)
// CastIntAsJson
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeJSON), intColumn)
require.NoError(t, err)
exprs = append(exprs, function)
// CastRealAsJson
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeJSON), realColumn)
require.NoError(t, err)
exprs = append(exprs, function)
// CastDecimalAsJson
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeJSON), decimalColumn)
require.NoError(t, err)
exprs = append(exprs, function)
// CastStringAsJson
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeJSON), stringColumn)
require.NoError(t, err)
exprs = append(exprs, function)
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeJSON), binaryStringColumn)
require.NoError(t, err)
exprs = append(exprs, function)
// CastTimeAsJson
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeJSON), datetimeColumn)
require.NoError(t, err)
exprs = append(exprs, function)
// CastDurationAsJson
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeJSON), durationColumn)
require.NoError(t, err)
exprs = append(exprs, function)
// CastJsonAsJson
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeJSON), jsonColumn)
require.NoError(t, err)
exprs = append(exprs, function)
pushed, remained = PushDownExprs(ctx, exprs, client, kv.TiFlash)
require.Len(t, pushed, len(exprs))
require.Len(t, remained, 0)

3
pkg/expression/expression.go
View File

@ -1237,6 +1237,9 @@ func scalarExprSupportedByFlash(function *ScalarFunction) bool {
return function.GetArgs()[0].GetType().GetType() != mysql.TypeYear
case tipb.ScalarFuncSig_CastTimeAsDuration:
return retType.GetType() == mysql.TypeDuration
case tipb.ScalarFuncSig_CastIntAsJson, tipb.ScalarFuncSig_CastRealAsJson, tipb.ScalarFuncSig_CastDecimalAsJson, tipb.ScalarFuncSig_CastStringAsJson,
tipb.ScalarFuncSig_CastTimeAsJson, tipb.ScalarFuncSig_CastDurationAsJson, tipb.ScalarFuncSig_CastJsonAsJson:
return true
}
case ast.DateAdd, ast.AddDate:
switch function.Function.PbCode() {