database/tidb
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #591 from pingcap/c4pt0r/cleanup

Browse Source 
hbase-store: use rand instead of timestamp for selecing connection randomly
This commit is contained in:
dongxu
2015-11-16 11:20:23 +08:00
parent 9d4230f84f 4960a63b81
commit e78a3afe18
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
store/hbase/kv.go
View File

@ -14,6 +14,7 @@
package hbasekv
import (
"math/rand"
"strings"
"sync"
"time"
@ -59,6 +60,7 @@ var mc storeCache
func init() {
mc.cache = make(map[string]*hbaseStore)
rand.Seed(time.Now().UnixNano())
}
type hbaseStore struct {
@ -68,11 +70,15 @@ type hbaseStore struct {
conns []hbase.HBaseClient
}
func (s *hbaseStore) getHBaseClient() hbase.HBaseClient {
// return hbase connection randomly
return s.conns[rand.Intn(hbaseConnPoolSize)]
}
func (s *hbaseStore) Begin() (kv.Transaction, error) {
s.mu.Lock()
defer s.mu.Unlock()
// get random conn
hbaseCli := s.conns[time.Now().UnixNano()%hbaseConnPoolSize]
hbaseCli := s.getHBaseClient()
t := themis.NewTxn(hbaseCli)
txn := newHbaseTxn(t, s.storeName)
txn.UnionStore = kv.NewUnionStore(newHbaseSnapshot(t, s.storeName))
@ -80,8 +86,7 @@ func (s *hbaseStore) Begin() (kv.Transaction, error) {
}
func (s *hbaseStore) GetSnapshot(ver kv.Version) (kv.MvccSnapshot, error) {
// get random conn
hbaseCli := s.conns[time.Now().UnixNano()%hbaseConnPoolSize]
hbaseCli := s.getHBaseClient()
t := themis.NewTxn(hbaseCli)
return newHbaseSnapshot(t, s.storeName), nil
}
@ -108,7 +113,7 @@ func (s *hbaseStore) UUID() string {
}
func (s *hbaseStore) CurrentVersion() (kv.Version, error) {
hbaseCli := s.conns[time.Now().UnixNano()%hbaseConnPoolSize]
hbaseCli := s.getHBaseClient()
t := themis.NewTxn(hbaseCli)
defer t.Release()