github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-06-05 18:04:33 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Notifications: Updated comment notif. prefs. test

Browse Source 
Combined testcases, updated to use actual text strings, and set comments
setting via correct method.

Made during review of #4552
This commit is contained in:
Dan Brown
2023-09-17 22:26:51 +01:00
parent baa957d980
commit c42cd29ed3
1 changed files with 13 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
tests/User/UserPreferencesTest.php
View File

@ -156,6 +156,19 @@ class UserPreferencesTest extends TestCase
$this->assertPermissionError($resp);
}
public function test_notification_comment_options_only_exist_if_comments_active()
{
$resp = $this->asEditor()->get('/preferences/notifications');
$resp->assertSee('Notify upon comments');
$resp->assertSee('Notify upon replies');
setting()->put('app-disable-comments', true);
$resp = $this->get('/preferences/notifications');
$resp->assertDontSee('Notify upon comments');
$resp->assertDontSee('Notify upon replies');
}
public function test_update_sort_preference()
{
$editor = $this->users->editor();
@ -318,35 +331,4 @@ class UserPreferencesTest extends TestCase
$resp = $this->get($page->getUrl('/edit'));
$resp->assertSee('option:code-editor:favourites="javascript,ruby"', false);
}
public function test_comment_notifications_hidden_when_comments_disabled()
{
$editor = $this->users->editor();
setting()->putUser($editor, 'app-disable-comments', true);
$settingLabel1 = trans('preferences.notifications_opt_own_page_comments');
$settingLabel2 = trans('preferences.notifications_opt_comment_replies');
$resp = $this->actingAs($editor)->get('/preferences/notifications');
$resp->assertDontSee($settingLabel1, true);
$resp->assertDontSee($settingLabel2, true);
}
public function test_comment_notifications_visible_when_comments_enabled()
{
$editor = $this->users->editor();
setting()->putUser($editor, 'app-disable-comments', false);
$settingLabel1 = trans('preferences.notifications_opt_own_page_comments');
$settingLabel2 = trans('preferences.notifications_opt_comment_replies');
$resp = $this->actingAs($editor)->get('/preferences/notifications');
$resp->assertSee($settingLabel1, true);
$resp->assertSee($settingLabel2, true);
}
}