github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 13:45:09 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Ensure sidebar sections are collapsable in mobile view (#31383)

Browse Source
This commit is contained in:
Sérgio Saquetim
2025-02-19 16:05:43 -03:00
committed by GitHub
parent 3e22fc8ba2
commit 0abc33c5a2
2 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/assets/javascripts/discourse/app/components/sidebar/hamburger-dropdown.gjs
View File

@ -33,13 +33,10 @@ export default class SidebarHamburgerDropdown extends Component {
}
get collapsableSections() {
if (
this.siteSettings.navigation_menu === "header dropdown" &&
!this.args.collapsableSections
) {
return this.site.mobileView || this.site.narrowDesktopView;
if (this.site.mobileView || this.site.narrowDesktopView) {
return true;
} else {
this.args.collapsableSections;
return this.args.collapsableSections;
}
}

21
app/assets/javascripts/discourse/tests/acceptance/sidebar-user-test.js
View File

@ -77,6 +77,27 @@ acceptance(
}
);
acceptance(
"Sidebar - Logged on user - Mobile view - Sidebar enabled",
function (needs) {
needs.user();
needs.mobileView();
needs.settings({
navigation_menu: "sidebar",
});
test("sections are collapsable", async function (assert) {
await visit("/");
await click("#toggle-hamburger-menu");
assert
.dom(".sidebar-section-header.sidebar-section-header-collapsable")
.exists("sections are collapsable");
});
}
);
acceptance(
"Sidebar - Experimental sidebar and hamburger setting enabled - Sidebar enabled",
function (needs) {