github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-26 23:32:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

PERF: Remove caches from Category.subcategories & Category.descendents (#31829)

Browse Source 
Since d2409f2964e85a4cb134f119d1bdddce54156175, these calculations are
now incredibly cheap, and the caches introduced by `@computed` become
the bottleneck. On a site with 5k+ categories, removing these caches
results in a 4x render time improvement for their homepage (~2s ->
~0.5s).

Technically, this means these properties will no longer be reactive for
places that depend on them using computed property syntax. However, they
are still reactive for modern code with autotracking. Given that the set
of categories doesn't change after initial load, I think this is
acceptable. If we do run into any issues, then we can update the related
code to use autotracking.

Note: `@dependentKeyCompat` has similar perf overheads to `@computed`,
so that's why I haven't used that for backward-compat.
This commit is contained in:
David Taylor
2025-03-14 13:12:16 +00:00
committed by GitHub
parent af31058b55
commit 3de863c698
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse/app/models/category.js
View File

@ -503,12 +503,10 @@ export default class Category extends RestModel {
this.set("parent_category_id", newParentCategory?.id);
}
@computed("site.categoriesByParentId")
get subcategories() {
return this.site.categoriesByParentId.get(this.id) || [];
}
@computed("subcategories")
get unloadedSubcategoryCount() {
return this.subcategory_count - this.subcategories.length;
}
@ -560,8 +558,7 @@ export default class Category extends RestModel {
}
}
@discourseComputed("subcategories")
descendants() {
get descendants() {
const descendants = [this];
for (let i = 0; i < descendants.length; i++) {
if (descendants[i].subcategories) {