mirror of
https://github.com/discourse/discourse.git
synced 2025-06-04 11:11:13 +08:00
FIX: wizard logo preview (#32543)
Bug introduced in this commit - https://github.com/discourse/discourse/commit/e41897a3066
This commit is contained in:

committed by
GitHub

parent
4e3d9d88ea
commit
4cd5e7070b
@ -1,6 +1,5 @@
|
||||
import Component from "@ember/component";
|
||||
import { warn } from "@ember/debug";
|
||||
import { getOwner } from "@ember/owner";
|
||||
import { service } from "@ember/service";
|
||||
import { dasherize } from "@ember/string";
|
||||
import { classNames } from "@ember-decorators/component";
|
||||
@ -21,8 +20,7 @@ export default class Image extends Component {
|
||||
|
||||
@discourseComputed("field.id")
|
||||
previewComponent(id) {
|
||||
const name = imagePreviews[dasherize(id)] ?? imagePreviews.generic;
|
||||
return getOwner(this).resolveRegistration(`component:${name}`);
|
||||
return imagePreviews[dasherize(id)] ?? imagePreviews.generic;
|
||||
}
|
||||
|
||||
didInsertElement() {
|
||||
|
@ -67,9 +67,9 @@ To get you started, think about what you want new members to **know about your c
|
||||
|
||||
To customize the look and feel of your community beyond what you configured in the [setup wizard](%{base_url}/wizard), you can change the following settings in the [admin interface](%{base_url}/admin):
|
||||
|
||||
- [Logo images](%{base_url}/admin/config/logo)
|
||||
- [Logo images](%{base_url}/admin/config/logo-and-fonts)
|
||||
- [Color palettes](%{base_url}/admin/customize/colors)
|
||||
- [Font styles](%{base_url}/admin/config/fonts)
|
||||
- [Font styles](%{base_url}/admin/config/logo-and-fonts)
|
||||
- [Site theme](%{base_url}/admin/customize/themes)
|
||||
- [Navigation menu](%{base_url}/admin/config/navigation)
|
||||
- [Custom user fields](%{base_url}/admin/config/user-fields)
|
||||
|
@ -86,6 +86,10 @@ class PageObjects::Pages::Wizard::BrandingStep < PageObjects::Pages::Wizard::Ste
|
||||
def has_upload?(field_id)
|
||||
wizard.find_field("image", field_id).has_css?(".wizard-container__button-upload.has-upload")
|
||||
end
|
||||
|
||||
def has_preview?(field_id)
|
||||
wizard.find_field("image", field_id).has_css?(".wizard-container__preview")
|
||||
end
|
||||
end
|
||||
|
||||
class PageObjects::Pages::Wizard::StylingStep < PageObjects::Pages::Wizard::StepBase
|
||||
|
@ -67,8 +67,10 @@ describe "Wizard", type: :system do
|
||||
expect(wizard_page).to be_on_step("branding")
|
||||
attach_file(file_path_1) { wizard_page.branding_step.click_upload_button("logo") }
|
||||
expect(wizard_page.branding_step).to have_upload("logo")
|
||||
expect(wizard_page.branding_step).to have_preview("logo")
|
||||
attach_file(file_path_2) { wizard_page.branding_step.click_upload_button("logo-small") }
|
||||
expect(wizard_page.branding_step).to have_upload("logo-small")
|
||||
expect(wizard_page.branding_step).to have_preview("logo-small")
|
||||
wizard_page.go_to_next_step
|
||||
expect(wizard_page).to be_on_step("ready")
|
||||
|
||||
|
Reference in New Issue
Block a user