github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-19 06:49:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: iconList is an array in production (#11308)

Browse Source 
This should be investigated further, but hopefully the comment will prevent anyone else to fall in this trap.
This commit is contained in:
Joffrey JAFFEUX 2020-11-20 20:00:51 +01:00 committed by GitHub
parent 0ec62358d9
commit 8aa912c885
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse-common/addon/lib/icon-library.js
View File

@ -115,8 +115,9 @@ export function setIconList(iconList) {
}
export function isExistingIconId(id) {
// _iconList is actually an array as a string: '["foo", "bar"]'
return _iconList && _iconList.indexOf(`"${id}"`) >= 0;
// TODO: investigate why _iconList is actually an array as a string: '["foo", "bar"]'
// in local and a real array in production
return _iconList && _iconList.indexOf(id) >= 0;
}
function warnIfMissing(id) {