github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-06 00:24:39 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: broken query if upload id is missing (#9900)

Browse Source 
Log warnings if there are any errors trying to upload group flair image
and ensure upload.id exists before trying to use it in a sql query.
This commit is contained in:
Blake Erickson
2020-05-27 12:39:30 -06:00
committed by GitHub
parent a9d92f338e
commit a788427b46
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/jobs/onceoff/migrate_group_flair_images.rb
View File

@ -77,7 +77,11 @@ module Jobs
origin: UrlHelper.absolute(old_url)
).create_for(Discourse.system_user.id)
DB.exec("UPDATE groups SET flair_url = NULL, flair_upload_id = #{upload.id} WHERE id = #{group.id}") if upload.present?
if upload.errors.count > 0
logger.warn("Failed to create upload for '#{group_name}' group_flair: #{upload.errors.full_messages}")
else
DB.exec("UPDATE groups SET flair_url = NULL, flair_upload_id = #{upload.id} WHERE id = #{group.id}") if upload&.id.present?
end
end
end