github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-25 00:32:52 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: stop depending on hover for image resize icons

Browse Source 
We no longer defer render the resize links, so we no longer need all these
hover events to test it.

Corrects broken test.
This commit is contained in:
Sam Saffron
2019-10-29 16:01:15 +11:00
parent 001c593155
commit b92e4465f7
1 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/javascripts/acceptance/composer-test.js.es6
View File

@ -734,13 +734,6 @@ QUnit.test("Image resizing buttons", async assert => {
await fillIn(".d-editor-input", uploads.join("\n")); await fillIn(".d-editor-input", uploads.join("\n"));
assert.ok(
find(".button-wrapper").length === 0,
"it does not append scaling buttons before hovering images"
);
await triggerEvent($(".d-editor-preview img"), "mouseover");
assert.ok( assert.ok(
find(".button-wrapper").length === 6, find(".button-wrapper").length === 6,
"it adds correct amount of scaling button groups" "it adds correct amount of scaling button groups"
@ -750,34 +743,24 @@ QUnit.test("Image resizing buttons", async assert => {
await click(find(".button-wrapper .scale-btn[data-scale='50']")[0]); await click(find(".button-wrapper .scale-btn[data-scale='50']")[0]);
assertImageResized(assert, uploads); assertImageResized(assert, uploads);
await triggerEvent($(".d-editor-preview img"), "mouseover");
uploads[2] = "![anotherOne|690x463,75%](upload://anotherOne.jpeg)"; uploads[2] = "![anotherOne|690x463,75%](upload://anotherOne.jpeg)";
await click(find(".button-wrapper .scale-btn[data-scale='75']")[1]); await click(find(".button-wrapper .scale-btn[data-scale='75']")[1]);
assertImageResized(assert, uploads); assertImageResized(assert, uploads);
await triggerEvent($(".d-editor-preview img"), "mouseover");
uploads[7] = uploads[7] =
"![onTheSameLine1|200x200,50%](upload://onTheSameLine1.jpeg) ![onTheSameLine2|250x250](upload://onTheSameLine2.jpeg)"; "![onTheSameLine1|200x200,50%](upload://onTheSameLine1.jpeg) ![onTheSameLine2|250x250](upload://onTheSameLine2.jpeg)";
await click(find(".button-wrapper .scale-btn[data-scale='50']")[2]); await click(find(".button-wrapper .scale-btn[data-scale='50']")[2]);
assertImageResized(assert, uploads); assertImageResized(assert, uploads);
await triggerEvent($(".d-editor-preview img"), "mouseover");
uploads[7] = uploads[7] =
"![onTheSameLine1|200x200,50%](upload://onTheSameLine1.jpeg) ![onTheSameLine2|250x250,75%](upload://onTheSameLine2.jpeg)"; "![onTheSameLine1|200x200,50%](upload://onTheSameLine1.jpeg) ![onTheSameLine2|250x250,75%](upload://onTheSameLine2.jpeg)";
await click(find(".button-wrapper .scale-btn[data-scale='75']")[3]); await click(find(".button-wrapper .scale-btn[data-scale='75']")[3]);
assertImageResized(assert, uploads); assertImageResized(assert, uploads);
await triggerEvent($(".d-editor-preview img"), "mouseover");
uploads[8] = "![identicalImage|300x300,50%](upload://identicalImage.png)"; uploads[8] = "![identicalImage|300x300,50%](upload://identicalImage.png)";
await click(find(".button-wrapper .scale-btn[data-scale='50']")[4]); await click(find(".button-wrapper .scale-btn[data-scale='50']")[4]);
assertImageResized(assert, uploads); assertImageResized(assert, uploads);
await triggerEvent($(".d-editor-preview img"), "mouseover");
uploads[9] = "![identicalImage|300x300,75%](upload://identicalImage.png)"; uploads[9] = "![identicalImage|300x300,75%](upload://identicalImage.png)";
await click(find(".button-wrapper .scale-btn[data-scale='75']")[5]); await click(find(".button-wrapper .scale-btn[data-scale='75']")[5]);
assertImageResized(assert, uploads); assertImageResized(assert, uploads);
@ -791,8 +774,6 @@ QUnit.test("Image resizing buttons", async assert => {
` `
); );
await triggerEvent($(".d-editor-preview img"), "mouseover");
assert.ok( assert.ok(
find("script").length === 0, find("script").length === 0,
"it does not unescapes script tags in code blocks" "it does not unescapes script tags in code blocks"