github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-26 05:11:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: flakey due to 0 width/height images (#29700)

Browse Source 
https://github.com/mainmatter/qunit-dom/blob/master/API.md#isvisible will return true if offsetWidth or offsetHeight are zero which could happen in this case as the test could run before the image has loaded. By forcing a minimum height in the test we ensure it will be consistent.
This commit is contained in:
Joffrey JAFFEUX
2024-11-11 17:23:19 +09:00
committed by GitHub
parent 189d98f3ca
commit c4de8565ec
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/chat/test/javascripts/components/chat-message-collapser-test.js
View File

@ -13,9 +13,9 @@ const youtubeCooked =
const animatedImageCooked =
"<p>written text</p>" +
'<p><img src="/images/avatar.png" class="animated onebox"></img></p>' +
'<p><img src="/images/avatar.png" width="8" height="8" class="animated onebox"></img></p>' +
"<p>more written text</p>" +
'<p><img src="/images/d-logo-sketch-small.png" class="animated onebox"></img></p>' +
'<p><img src="/images/d-logo-sketch-small.png" width="8" height="8" class="animated onebox"></img></p>' +
"<p>and even more</p>";
const externalImageCooked =