github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-06 12:26:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Do not include CDN domain in the sourceMappingURL (#15887)

Browse Source 
If no path is supplied, browsers will look for the map on the same path as the JS file itself. This fixes two problems that we see in production:

1. When compiling assets against one CDN, and then re-using them on a site with a different CDN, the sourceMappingUrls would be incorrect and print warnings in the console

2. If both an S3 CDN and an app CDN are configured, we were using the S3 CDN for the JS and the app CDN for the map. This commit will make sure we use the S3 CDN for both.
This commit is contained in:
David Taylor
2022-02-10 15:37:44 +00:00
committed by GitHub
parent abefb1beff
commit fcae4a8faf
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/tasks/assets.rake
View File

@ -109,7 +109,7 @@ def compress_node(from, to)
assets = cdn_relative_path("/assets")
assets_additional_path = (d = File.dirname(from)) == "." ? "" : "/#{d}"
source_map_root = assets + assets_additional_path
source_map_url = cdn_path "/assets/#{to}.map"
source_map_url = "#{File.basename(to)}.map"
base_source_map = assets_path + assets_additional_path
cmd = <<~EOS