Commit Graph

45446 Commits

Author SHA1 Message Date
02e148cbde Version bump to v2.9.0.beta6 (#17283)
Needed for https://meta.discourse.org/t/unable-to-find-discourse-version-2-9-0-beta6/231511
2022-06-30 12:25:44 +03:00
Joe
c86c709998 UX: Reduces splash animation delay (#17282)
This PR cuts down the delay before the splash screen is visible.
2022-06-30 17:19:39 +08:00
3a6e87ca4f FEATURE: Store sidebar section display state in local storage (#17281)
Tests have been intentionally left out as it is hard to test interaction that relies on local storage.
It also isn't the end of the world if the feature regresses.
2022-06-30 15:56:46 +08:00
3266350e80 FEATURE: Decouple category/tag presence in sidebar from notifi level (#17273) 2022-06-30 14:54:20 +08:00
db53c6650b FIX: max value for SiteSetting.delete_removed_posts_after (#17270) 2022-06-30 12:46:48 +08:00
1493cc447e Build(deps): Bump rubocop from 1.31.0 to 1.31.1 (#17280)
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.31.0 to 1.31.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.31.0...v1.31.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-30 12:45:32 +08:00
09932738e5 FEATURE: whispers available for groups (#17170)
Before, whispers were only available for staff members.

Config has been changed to allow to configure privileged groups with access to whispers. Post migration was added to move from the old setting into the new one.

I considered having a boolean column `whisperer` on user model similar to `admin/moderator` for performance reason. Finally, I decided to keep looking for groups as queries are only done for current user and didn't notice any N+1 queries.
2022-06-30 10:18:12 +10:00
f44eb13236 FIX: add clearfix back for admin contents (#17278) 2022-06-29 10:17:01 -04:00
657256a099 Revert "DEV: Use performance.timing as a baseline for the splash (#17275)" (#17276)
This reverts commit 6146da5eb71da2942fa3da9dfdd8a5cc5f3734d9.
2022-06-29 18:34:37 +08:00
Joe
6146da5eb7 DEV: Use performance.timing as a baseline for the splash (#17275)
* update styles

* remove unused code

* use request time as a baseline
2022-06-29 20:01:46 +10:00
Sam
6ecfdc8f55 FIX: keep unique post checks separate for PMs vs topics (#17272)
This allows for people to use PMs for drafting and then post them on topics.

Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2022-06-29 15:35:07 +10:00
644e05cd4d DEV: Rename variable in TagSectionLink JavaScript class (#17274)
Tag is vague and is mostly used in our code base to represent a Tag
ember object.
2022-06-29 13:18:30 +08:00
f070ebca9d Build(deps): Bump rack-test from 2.0.1 to 2.0.2 (#17269)
Bumps [rack-test](https://github.com/rack/rack-test) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/rack/rack-test/releases)
- [Changelog](https://github.com/rack/rack-test/blob/main/History.md)
- [Commits](https://github.com/rack/rack-test/compare/v2.0.1...v2.0.2)

---
updated-dependencies:
- dependency-name: rack-test
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-29 10:49:47 +08:00
f0005401b7 UX: core adjustments and styles for the experimental sidebar (#17271) 2022-06-29 10:49:01 +08:00
9d870f151c FIX: Uploading large files (> 5GB) failed when enable_direct_s3_uploads is enabled (#16724)
Larger files require a multipart copy.
2022-06-28 21:30:00 +02:00
0bcc478635 DEV: Run some specs with fake S3 implementation instead of stubs 2022-06-28 21:27:52 +02:00
235f172b9c FIX: Didn't delete upload stub when a new upload is created
Reuse `Discourse.store` to prevent creation of multiple new store objects within `UploadCreator#create_for`.
2022-06-28 21:27:52 +02:00
2d6ef232a7 FIX: Markdown handling failed on empty attribute value (#17199)
Seems to only be a problem when a markdown.it rule inserts links without a attribute value. There's no test, because it's not reproducible with the markdown rules in core.
2022-06-28 21:27:15 +02:00
809f3d37cd DEV: Update qunit-dom (#17265) 2022-06-28 21:22:17 +02:00
302fab07a3 DEV: Update jsdom (#17264) 2022-06-28 21:22:06 +02:00
bfeee1b803 DEV: Update sinon (#17266) 2022-06-28 21:21:51 +02:00
16f22e3c36 DEV: Add --forward-host option to bin/ember-cli (#17244)
This allows to e.g. test multisite setup in a local dev environment. Also fixes some minor proxy issues.
2022-06-28 21:20:14 +02:00
39a025c7af DEV: Allow newer versions of node (#17261)
It should now properly work with 18.x, so we should start moving into direction of it being the default.
2022-06-28 20:52:31 +02:00
c6b3d3e4b4 Update translations (#17267) 2022-06-28 20:52:09 +02:00
836b5300fc DEV: Move sidebar utility class to body tag (#17259) 2022-06-28 11:32:06 -04:00
4821d44c3c DEV: Update webpack (#17262) 2022-06-28 14:39:09 +02:00
a832c94527 UX: update color on arrow tippy box (#17263) 2022-06-28 13:25:40 +02:00
ff77ad7ac0 UX: Change copy for user-selector placeholder (#17260) 2022-06-28 19:01:16 +08:00
aa38dcd263 Build(deps): Bump rubocop from 1.30.1 to 1.31.0 (#17258)
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.30.1 to 1.31.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.30.1...v1.31.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-28 00:10:41 +02:00
5840fb5c62 UX: Update topics stats automatically (#17135)
Updates automatically data on the stats section of the topic.

It will update automatically the following information: likes, replies and last reply (timestamp and user)
2022-06-27 18:21:05 -03:00
31a0bf11f2 Build(deps): Bump rack-test from 1.1.0 to 2.0.1 (#17257)
Bumps [rack-test](https://github.com/rack/rack-test) from 1.1.0 to 2.0.1.
- [Release notes](https://github.com/rack/rack-test/releases)
- [Changelog](https://github.com/rack/rack-test/blob/main/History.md)
- [Commits](https://github.com/rack/rack-test/compare/v1.1.0...v2.0.1)

---
updated-dependencies:
- dependency-name: rack-test
  dependency-type: indirect
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-27 22:13:46 +02:00
a7284d3b96 DEV: Auto-allow multisite hosts in dev (#17246) 2022-06-27 21:58:33 +02:00
2b80133819 FIX: Fix bulk_invite flaky tests (#17256) 2022-06-27 14:50:20 -05:00
f56c44d1c7 FEATURE: Validate tags in WatchedWords (#17254)
* FEATURE: Validate tags in WatchedWords

We didn't validate watched words automatic tagging, so it was possible
for an admin to created watched words with an empty tag list which would
result in an exception when users tried to create a new topic that
matched the misconfigured watched word.

Bug report: https://meta.discourse.org/t/lib-topic-creator-fails-when-the-word-math-appears-in-the-topic-title-or-text/231018?u=falco
2022-06-27 16:16:33 -03:00
64adf3cba3 DEV: Don't template-lint all files in lefthook (#17255)
Just templates is a-ok, thx :P
2022-06-27 20:01:13 +02:00
aabb98aedc DEV: Deprecate DISCOURSE_DEV_HOSTS (#17245)
`RAILS_DEVELOPMENT_HOSTS` is a Rails standard that does exactly the same thing.
2022-06-27 19:04:42 +02:00
94e59ad9b6 DEV: Update html-entities (#17250) 2022-06-27 18:40:58 +02:00
f8691d12e1 DEV: Update ember-cli-app-version (#17253) 2022-06-27 18:13:56 +02:00
f505221a9c DEV: Update ember-cli-terser (#17252) 2022-06-27 18:13:46 +02:00
1344e7d62c DEV: Update js-yaml (#17249) 2022-06-27 18:13:29 +02:00
6a2ea012c7 DEV: Update @glimmer/tracking (#17248) 2022-06-27 18:13:04 +02:00
312fd4a26e Build(deps): Bump unicode-display_width from 2.1.0 to 2.2.0 (#17243)
Bumps [unicode-display_width](https://github.com/janlelis/unicode-display_width) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/janlelis/unicode-display_width/releases)
- [Changelog](https://github.com/janlelis/unicode-display_width/blob/main/CHANGELOG.md)
- [Commits](https://github.com/janlelis/unicode-display_width/compare/v2.1.0...v2.2.0)

---
updated-dependencies:
- dependency-name: unicode-display_width
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-27 12:12:48 +02:00
e7b627be49 Build(deps): Bump pg from 1.4.0 to 1.4.1 (#17242)
Bumps [pg](https://github.com/ged/ruby-pg) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/ged/ruby-pg/releases)
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.rdoc)
- [Commits](https://github.com/ged/ruby-pg/compare/v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: pg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-27 12:12:28 +02:00
85668d7da6 Build(deps-dev): Bump parallel_tests from 3.11.0 to 3.11.1 (#17241)
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 3.11.0 to 3.11.1.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md)
- [Commits](https://github.com/grosser/parallel_tests/compare/v3.11.0...v3.11.1)

---
updated-dependencies:
- dependency-name: parallel_tests
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-27 12:12:08 +02:00
9874fe3fb3 FIX: Improve mixcloud oneboxing (#17237)
- Sets `https://www.mixcloud.com` as a `requires_iframe_origins` to allow the iframe content to be displayed
- Attempts to render something approximating the Mixcloud content in the preview pane of the Composer, rather than just displaying a large version of the artwork associated with the link
2022-06-27 08:32:24 +10:00
Joe
526115f11a FIX: Defer removing the splash screen until the window load event fires take 3 (#17238)
We currently remove the splash screen once Discourse starts booting.

This can be an issue on very slow devices, which can take up to 6 seconds. This PR ensures that we don't remove the splash until the browser has finished parsing all of the site's assets. It won't impact fast devices.

Internal topic /t/65378/60
2022-06-25 12:59:16 +08:00
305c4750df UX: allow more mobile topic elements to be tapped (#17234) 2022-06-24 15:55:52 -04:00
c672144c14 DEV: Fix flaky tests caused by timezone updates (#17232)
Hopefully fixes flakes like:

```
not ok 1123 Chrome 102.0 - [undefined ms] - Global error: Uncaught Error: Unhandled request in test environment: /forum/u/eviltrout.json (PUT) at http://localhost:7357/assets/vendor.js, line 38378
 While executing test: Unit | Utility | click-track: routes to absolute internal urls
    ---
        browser log: |
            {"type":"error","text":"Unhandled request in test environment: /forum/u/eviltrout.json (PUT)"}
            {"type":"error","text":"Uncaught Error: Unhandled request in test environment: /forum/u/eviltrout.json (PUT) at http://localhost:7357/assets/vendor.js, line 38378\n","testContext":{"id":1123,"name":"Unit | Utility | click-track: routes to absolute internal urls","items":[],"state":"executing"}}
    ...
```
2022-06-24 19:19:11 +02:00
9669794f85 DEV: Remove more legacy ember code (#17218)
Also fixes flaky d-editor tests
2022-06-24 18:56:08 +02:00
Joe
f73796b258 FIX: Skip the window load event for now (#17231) 2022-06-24 19:23:33 +08:00