Commit Graph

33293 Commits

Author SHA1 Message Date
b05d7042ae FIX: prevents events on toolbar when in form (#7567)
If a button is not of type button, pressing enter inside an `<input>` inside a `<form>` without the action attribute will trigger the first available `<button>` as most browsers default the type of an unspecified button to submit.

This commit also prevents d-editor-modal to be filled when it's hidden.
2019-05-17 11:14:09 +02:00
105359e54a FIX: Only delete theme folder if it has been created
If an exception is raised before the folder is created, then this `ensure` block is still run
2019-05-17 09:45:11 +01:00
148bfc9be5 DEV: Simplify client and server side code to support removing tags.
Follow up to 834c86678fc9b0900d8ce83365068c41bc34f63f.
2019-05-17 16:39:20 +08:00
678a9a61c4 DEV: lint importer
commit #f490ed3b introduced a few linting issues, resolved now
2019-05-17 16:37:08 +10:00
f490ed3bbc FEATURE: Add attachment support to xenforo importer (#7548)
* FEATURE: Add attachment support to XenForo importer

If `ATTACHMENT_DIR` is provided, importer will scan each imported post
for `[GALLERY]` and `[ATTACH]` tags, attempt to import the referenced files
as Discourse uploads and replace the tags with Discourse markup.

References to files which cannot be imported are stripped.

NOTE: This only imports attachments which are referenced in imported
posts. Any XenForo media or files which are not referenced in any post
using `[ATTACH]` or `[GALLERY]` tags will not be imported. The goal is to
ensure that we don't have posts with missing images and unsightly
markup, NOT to ensure that all attachments are migrated.

* FEATURE: Add attachment support to XenForo importer

If `ATTACHMENT_DIR` is provided, importer will scan each imported post
for `[GALLERY]` and `[ATTACH]` tags, attempt to import the referenced files
as Discourse uploads and replace the tags with Discourse markup.

References to files which cannot be imported are stripped.

NOTE: This only imports attachments which are referenced in imported
posts. Any XenForo media or files which are not referenced in any post
using `[ATTACH]` or `[GALLERY]` tags will not be imported. The goal is to
ensure that we don't have posts with missing images and unsightly
markup, NOT to ensure that all attachments are migrated.

* FEATURE: Add attachment support to XenForo importer

If `ATTACHMENT_DIR` is provided, importer will scan each imported post
for `[GALLERY]` and `[ATTACH]` tags, attempt to import the referenced files
as Discourse uploads and replace the tags with Discourse markup.

References to files which cannot be imported are stripped.

NOTE: This only imports attachments which are referenced in imported
posts. Any XenForo media or files which are not referenced in any post
using `[ATTACH]` or `[GALLERY]` tags will not be imported. The goal is to
ensure that we don't have posts with missing images and unsightly
markup, NOT to ensure that all attachments are migrated.
2019-05-17 16:18:28 +10:00
aeb7143aff DEV: correct flaky poll specs
They were relying on a pristine message bus, however current implementation
still uses redis, stuff can get held up and we can end up publishing
distributed cache messages in the middle invalidating the tests
2019-05-17 16:16:02 +10:00
b983b6cb87 SECURITY: lodash 4.17.11 (#7565)
This version also now includes _.find
2019-05-17 07:57:05 +02:00
5666316285 FEATURE: Display 'last updated' on dashboard, improve release notes link (#7560) 2019-05-17 15:42:45 +10:00
834c86678f FIX: Missing post revision when editing the first post. 2019-05-17 12:54:27 +08:00
e2444e0d31 DEV: Fix another frozen string error. 2019-05-17 10:07:37 +08:00
96fbc14f80 DEV: quick setup is no longer maintained
Removing this for now as it is not maintained
2019-05-17 11:50:05 +10:00
b3d42b3f18 DEV: remove unmaintained script
osxdev script has not been maintained for a while, keeping it around is
only causing confusion
2019-05-17 11:47:48 +10:00
ba84e33b63 copyedits 2019-05-16 17:40:15 -07:00
25137554ed FIX: _.include is no longer imported from lodash
Instead use toArray and indexOf which is also clearer
2019-05-17 08:58:39 +10:00
fd1ae16f3b FIX: wrong file used when updating lodash (#7564) 2019-05-17 00:32:58 +02:00
87c2cbe062 DEV: Enable invite_spec test again 2019-05-16 18:55:36 -03:00
314a16bd37 Remove unused translation
7eea55d5
2019-05-16 14:41:11 -04:00
3363b84de6 Fix linting errors 2019-05-16 15:33:27 -03:00
b716439c3e DEV: Improve component test skip option and skipped new tests 2019-05-16 15:15:37 -03:00
80b3560050 IE11: Login form needs full flex shorthand 2019-05-16 14:07:49 -04:00
225593d445 FIX: Small tweak to percentiles based on feedback 2019-05-16 13:45:36 -04:00
f41aa5cb98 EXPERIMENTAL: attempts to gather info if chrome runner crashed (#7562) 2019-05-16 18:00:57 +02:00
77b78968c9 DEV: adds findIndex to lodash (#7561) 2019-05-16 17:00:25 +02:00
b5dd4478e5 FIX: Blocked watched words should apply to staff (#7547)
Having different behavior for staff and regular users can make it confusing for admins to understand how their configuration changes affect regular users
2019-05-16 15:19:41 +01:00
ad4d01233b DEV: attempts to make d-editor tests more resilient (#7556) 2019-05-16 14:42:01 +02:00
244c03573a FIX: btn class was duplicated on admin-menu-buttons (#7555) 2019-05-16 14:37:53 +02:00
0c6ebe66ce EXPERIMENTAL: clicks outside seem unreliable with absolute nodes (#7557) 2019-05-16 14:37:37 +02:00
1afe6d0aee FIX: share-and-invite modal was too narrow (#7559) 2019-05-16 14:37:19 +02:00
9ce9d72e71 DEV: makes hidepassed default when running qunit (#7558)
Mostly useful when not running headless, but I endup doing it a lot when debugging, one less thing to check.
2019-05-16 14:37:01 +02:00
0e677daaee FIX: include posts with data-orig-src attribute in have_uploads scope query. 2019-05-16 16:39:38 +05:30
3172172b52 remove unused local variable
ec84c87ddbae307405951fe6606f348c26bc2b07
2019-05-16 15:39:13 +05:30
ec84c87ddb FIX: skip validation while recovering uploads from s3
TODO: add tests
2019-05-16 15:37:11 +05:30
56ada8374f DEV: wrap find_missing_uploads method in distributed mutex
And skip posts with deleted topics.\ne8fafbc123170dd1f7d2a8adea4e7810585d3e76
2019-05-16 15:17:53 +05:30
a5a4f9dc1a DEV: make prettier happy
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
d51a495dad COPY: improve 'private_email' site setting description 2019-05-16 11:35:33 +02:00
5dd97d6d38 DEV: prevent already defined global warning 2019-05-16 11:32:10 +02:00
4a9756ff3f DEV: sets rack server to test env when using rake qunit:test (#7554) 2019-05-16 10:44:29 +02:00
d47bf8b6c4 SECURITY: updates lodash from 1.3.0 to 4.17.5 (#7546) 2019-05-16 10:34:19 +02:00
cabc203885 Followup to a8fbb19e
Correct edge condition where no available names are found

- increase search space
- search for 10 extra names
2019-05-16 18:15:56 +10:00
a8fbb19e7c FEATURE: allow a huge number of users to share common prefix
Previously username suggester would give up after 100 attempts at getting
a username and fallback to random string.

This amends the logic so we do all the work of figuring out a good username
in SQL and avoids a large amount of queries in cases where a lot of usernames
were used up.

This corrects an issue on sites with large numbers of anon users
2019-05-16 17:15:16 +10:00
ea214b2b0c DEV: logs tests exception when running qunit on headless chrome (#7553) 2019-05-16 08:48:08 +02:00
a36fe019bb DEV: Fix race condition when enqueuing edit wiki-ed notification. 2019-05-16 13:48:46 +08:00
636b75fa16 REFACTOR: remove duplicate reject loop and implicit return
e8fafbc123170dd1f7d2a8adea4e7810585d3e76
2019-05-16 10:04:04 +05:30
40328f055e FIX: retrieve original filename from s3 object's content disposition header 2019-05-16 09:47:22 +05:30
227bedebf7 DEV: Fix modifying a frozen string. 2019-05-16 11:30:31 +08:00
dd49be27d3 DEV: Fix undefined variable.
Follow up to e8fafbc123170dd1f7d2a8adea4e7810585d3e76.
2019-05-16 11:28:48 +08:00
76173dea87 DEV: ensure we never fork v8 contexts from unicorn
v8 forking is not supported and can lead to memory leaks.

This commit handles the most common case which is the unicorn master forking

There are still some cases related to backup where we fork, however those
forks are usually short lived so the memory leak is not severe, burning
the contexts in the master process could break sidekiq or web process that
do the actual forking
2019-05-16 09:50:34 +10:00
7cd1067f3d FIX: Select-kit too narrow in topic timer 2019-05-15 17:58:40 -04:00
2932b0e757 chore: bump ruby version in .ruby-version (#7552) 2019-05-15 23:47:51 +02:00
501bee56b7 Make prettier happy 2019-05-15 23:46:50 +02:00