81c329fbb8
FIX: Customizing missing pluralized translations didn't work
2019-05-13 09:36:05 +02:00
6d44be5142
FIX: Catch InvalidPluralizationData exception in fallback locales
...
It shouldn't raise an exception when a pluralized string in a fallback locale is only partially translated.
2019-05-13 09:36:05 +02:00
a3e4f43a4d
DEV: Remove patch for I18n.exists?
...
It was merged upstream a long time ago
2019-05-13 09:36:05 +02:00
73015521e2
FIX: Correctly calculate fallback locale list
...
* English shouldn't fallback to any other locale
* Calculate fallback for default locale if it isn't English (useful for en_US)
* Reuse the fallback locale list when outputting translations to JavaScript
2019-05-13 09:36:05 +02:00
3fbab595d9
FEATURE: use the exact name provided by auth provider
...
Previously we would attempt to titleize it causing names like McDonald's
not to work as expected
2019-05-13 16:45:24 +10:00
d369b84ced
Fix modifying frozen strings error.
2019-05-13 14:31:20 +08:00
ba913a24db
Add steam login to official plugin list.
2019-05-13 12:39:35 +08:00
c00dab89e4
Fix the build take 2.
2019-05-13 11:22:48 +08:00
8c4caac2e4
Fix frozen string error in plugin:install_all_official.
2019-05-13 10:19:02 +08:00
9059a8ca90
Fix the build.
2019-05-13 10:16:26 +08:00
8165ceb320
Make rubocop happy.
2019-05-13 09:55:44 +08:00
888e68a163
FIX: When mutating a string to build a diff. Duplicate it first
...
Co-authored-by: Roman Rizzi <rizziromanalejandro@gmail.com >
2019-05-13 09:31:32 +08:00
982c4496ee
Correct some missing spots for frozen_string_literal
2019-05-13 09:31:32 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
4e1f25197d
FEATURE: allow overriding download of maxmind db via env
2019-05-13 09:58:56 +10:00
a859ddc77e
Improve theme/component delete modal warning
2019-05-10 14:14:12 -04:00
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases ( #7525 )
2019-05-10 17:12:10 +02:00
01bd82139f
FIX: Invalid URL for queued posts review
2019-05-10 10:00:52 -04:00
b3873b95d0
FIX: Pluralization error for tag error message
2019-05-10 09:54:54 -04:00
643c75c419
FIX: Don't increment version if the reviewable operation fails
...
In fact, roll back the entire operation in the database.
2019-05-10 09:53:25 -04:00
bf7594b327
More prefabrication
2019-05-10 08:34:04 -04:00
54cfc48975
Use prefabricated users in bulk_invite_spec.rb
2019-05-10 08:34:04 -04:00
6e11ae06d8
Prefabricate admin in wizard_spec.rb
2019-05-10 08:34:04 -04:00
bc4748571e
Moved fabrication of topic to top level in topics_bulk_action_spec.rb
2019-05-10 08:34:04 -04:00
90c226949c
prefabricate admin in search_spec.rb
2019-05-10 08:34:04 -04:00
6f5fb020d2
Prefabricate users in post_revisor_spec.rb
2019-05-10 08:34:04 -04:00
cbcfc89fac
prefabrication of users in flag_query_spec.rb
2019-05-10 08:34:04 -04:00
20daa76829
DEV: Change priority to ultra_low for post-s3-migration rebake
2019-05-10 18:37:45 +08:00
abbe812a0d
FIX: Correct CSS for instagram video play icon
2019-05-10 10:46:07 +01:00
2c6b595eed
FIX: Process image onebox correctly when image is wrapped in a link
...
The instagram onebox sometimes surrounds the image with an `<a>` tag, which was breaking the aspect ratio logic, and therefore causing posts to change height on load.
2019-05-10 10:02:40 +01:00
4096d559b5
REFACTOR: user-stream model ( #7515 )
2019-05-10 10:05:43 +02:00
a85b7feef4
REFACTOR: composer controller ( #7516 )
2019-05-10 10:05:29 +02:00
7aedc92a35
REFACTOR: login-controller ( #7514 )
2019-05-10 10:05:11 +02:00
63a3caa516
FIX: Don't display option for users to flag and notify a bot.
2019-05-10 10:05:03 +08:00
0ab6c6e24e
PERF: speed up spec suite, avoid featuring topics
...
Before: 6:05
After: 5:42
Featuring topics for `list/categories` is a very expensive operation that
happened each time we created a topic. This introduces a test only bypass
2019-05-10 11:37:53 +10:00
41f4f9302d
UX: Rename discobot tutorial triggers.
...
We found the previous triggers less straight forward than just calling
it tutorial.
`start new user` -> `start tutorial`
`start new advanced user` -> `start advanced tutorial`
2019-05-10 09:08:16 +08:00
ce15f085c6
DEV: Return the right response code and error message.
...
Follow up to d1dbafebbc4b21c2a6714cd19c0ba05fac7717c4.
Also remove test that is a duplicate of
867c1a5ac9355aadef35d60fd9c7aa4ebd0eda25.
2019-05-10 07:33:02 +08:00
4a1755b780
FIX: Don't create staged users when processing forwarded email fails
2019-05-09 23:47:47 +02:00
ccc1e85bf4
REFACTOR: Shorten up category param check
...
Follow up to d1dbafebbc4b21c2a6714cd19c0ba05fac7717c4
2019-05-09 14:35:36 -06:00
34684af195
FIX: Show error message if message exists
2019-05-09 22:12:51 +02:00
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
8dfb15a2e5
FIX: Do not show self edits in Post Edits report. ( #7510 )
2019-05-09 20:39:17 +03:00
ea3004ef11
UX: Save scroll position in tags topic list. ( #7511 )
2019-05-09 20:39:03 +03:00
9758857a78
FIX: escape Vimeo iframe URL
2019-05-09 23:01:50 +05:30
d1dbafebbc
FIX: Return error if new topic category not found take 2
...
If creating a topic via the api as an admin and the category you specify
cannot be found an error will now be returned instead of just creating
the topic with no category. This will prevent accidental public topic
creation originally intended for a private category.
This commit is follow up to 535c594891ec703a3b2e57c1b1a3497373d2e1f6 and
still allows for the creation of topics where the category param is
blank.
2019-05-09 11:27:45 -06:00
b5c8f5f900
SPEC: ensure never remap readonly columns
...
Follow-up to bfcbfd78
2019-05-09 18:01:35 +02:00
2a45933ff2
FIX: reduce iPad app nav padding
2019-05-09 10:25:22 -04:00
c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. ( #7509 )
2019-05-09 14:08:10 +03:00
4e91839c97
FIX: Remove default val for colors step if a default theme has been set.
...
Running through the wizard after a default theme has been configured
will always revert the default theme to the light theme.
2019-05-09 17:25:09 +08:00
d110f252bb
DEV: Remove unsued option from spec.
2019-05-09 17:25:09 +08:00
