0b098566ff
REFACTOR: Remove _.union
2020-09-03 10:03:33 -04:00
e60d06d880
REFACTOR: Remove _.isString
2020-09-03 10:03:33 -04:00
b4444070b3
REFACTOR: Remove _.groupBy
2020-09-03 10:03:33 -04:00
1265a5f7c0
REFACTOR: Remove _.max
2020-09-03 10:03:33 -04:00
d06deb0c4f
REFACTOR: Remove _.chain
2020-09-03 10:03:33 -04:00
71ddcefffa
REFACTOR: Remove _.filter
2020-09-03 10:03:33 -04:00
87b3caf927
REFACTOR: Remove _.reject
2020-09-03 10:03:33 -04:00
2a4dfa83b0
REFACTOR: Remove _.omit
2020-09-03 10:03:33 -04:00
17bca14c4b
REFACTOR: Remove _.sortBy
2020-09-03 10:03:33 -04:00
2353794a30
REFACTOR: Remove _.findIndex
2020-09-03 10:03:33 -04:00
e3ec7b72d0
REFACTOR: Remove _.uniq and use ember version
2020-09-03 10:03:33 -04:00
66021abe41
REFACTOR: Remove _.first from codebase
2020-09-03 10:03:33 -04:00
55c9c54b8b
REFACTOR: Remove _.range and use ES6 instead
2020-09-03 10:03:33 -04:00
115b3b6921
REFACTOR: Remove _.isEmpty in favor of the existing version
2020-09-03 10:03:33 -04:00
65f6a92129
REFACTOR: Replace _.extend with Object.assign
2020-09-03 10:03:33 -04:00
2f11457263
REFACTOR: Use Array.isArray instead of _.isArray
2020-09-03 10:03:33 -04:00
b129abfc11
Build(deps-dev): Bump test-prof from 0.12.1 to 0.12.2 ( #10589 )
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 0.12.1 to 0.12.2.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-09-03 10:02:20 -04:00
5bb30d8016
FIX: whoops, linting
2020-09-03 12:10:11 +01:00
6518cac5cf
DEV: Add log rake task
...
Now, if you do `rake log db:migrate`, it'll run migrations, but with
logging enabled, so that you can see what is actually happening.
2020-09-03 11:43:30 +01:00
774dfc6e5f
Build(deps-dev): Bump rubocop-discourse from 2.3.1 to 2.3.2
...
Bumps [rubocop-discourse](https://github.com/discourse/rubocop-discourse ) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/discourse/rubocop-discourse/releases )
- [Commits](https://github.com/discourse/rubocop-discourse/compare/v2.3.1...v2.3.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-09-03 16:30:58 +08:00
67dec38f31
FIX: Gravatar download attempt if user is missing their email
...
It is possible that a user could exist without an email, if so we should
not enqueue a job to download their gravatar.
This commit resolves this error that can occur:
```
Job exception: undefined method `email' for nil:NilClass
/var/www/discourse/app/models/user.rb:1204:in `email'
/var/www/discourse/app/jobs/regular/update_gravatar.rb:12:in `execute'
```
This commit also fixes the original spec which actually was wrong. The
job never enqueued in the original spec and so the gravatar was never
actually updated and the test was checking if the two values were the
same, but they were both null and never updated, so of course they were
the same!
A new test has also been added to make sure the gravatar job isn't
enqueued when a user's email is missing.
2020-09-02 20:19:46 -06:00
d9b30308f1
Build(deps): Bump public_suffix from 4.0.5 to 4.0.6
...
Bumps [public_suffix](https://github.com/weppos/publicsuffix-ruby ) from 4.0.5 to 4.0.6.
- [Release notes](https://github.com/weppos/publicsuffix-ruby/releases )
- [Changelog](https://github.com/weppos/publicsuffix-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/weppos/publicsuffix-ruby/compare/v4.0.5...v4.0.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-09-03 09:53:59 +08:00
9954a677ab
FIX: don't send mailing list for post with empty content ( #10577 )
...
discourse-assign is creating posts with empty content to show that a specific user was assign/unassigned for a specific topic.
It is causing confusing emails with empty content
The bug was mentioned here: https://meta.discourse.org/t/again-on-empty-emails-and-notifications-generated-on-topic-assignment/162213
2020-09-03 08:58:25 +10:00
de038c0eab
FIX: highlightjs 10 requires some languages to be loaded before others ( #10584 )
...
cs is also not present in 10 and relies only on csharp file, but for cs alias to work csharp has to be loaded.
2020-09-02 21:32:57 +02:00
6a837c32e4
DEV: Add class to wizard HTML element
2020-09-02 14:53:38 -04:00
50827684d5
UX: Hide category settings badges checkbox when enable_badges is off
2020-09-02 11:23:59 -04:00
0a492829ea
Add category id to webhook post serializer
2020-09-02 10:42:51 -04:00
c6e336b519
REFACTOR: simplifies connectors code ( #10579 )
...
- directly uses factoryFor to avoid having to set owner later
- drops jquery usage
- renames view into component as I find it more explicit
2020-09-02 15:53:42 +02:00
879e274dc7
UX: wrap extra long links in GitHub oneboxes instead of overflowing
2020-09-02 21:50:57 +08:00
803841ca47
FIX: Remove font-famly property in .font- classes
2020-09-02 16:29:09 +03:00
31c1d57228
FIX: System message wasn't fully translatable
2020-09-02 15:24:25 +02:00
02f0637892
FIX: updates highlightjs to latest version to avoid a freeze ( #10578 )
...
Example repro of the freeze:
```
```css
[
```
2020-09-02 15:14:48 +02:00
ef68e11137
FIX: Check if invite has expired before showing it ( #10581 )
2020-09-02 13:24:49 +03:00
38c9c87128
FIX: Add to tags result set only visible tags ( #10580 )
2020-09-02 13:24:40 +03:00
fc7bd3e605
Build(deps): Bump rubocop from 0.89.1 to 0.90.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.89.1 to 0.90.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.89.1...v0.90.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-09-02 11:21:58 +08:00
d79f50a3c6
DEV: Remove rb-inotify gem from Gemfile
...
We are no longer directly referencing the rb-inotify gem directly in
code. This was just a spec level dependency anyways.
Using `git log -S "Inotify"` resulted in these two commits as usages of
`Inotify`:
- b56b11d96aafa5cd9e2f004ae631348fba4574ae
- 9cf03b352cb2bff7c9a7a56211d56a921ed13664
both from 2013, but we no longer are using inotify in
https://github.com/discourse/discourse/blob/master/lib/tasks/autospec.rake
which appears to be the only file that was using it.
Based on this info we can safely remove rb-inotify from the Gemfile.
Just as a side note we still do have a couple of gems that do have
rb-inotify as a dependency: listen, and lru_redux.
2020-09-02 11:21:40 +08:00
8ecd04cbe4
Build(deps-dev): Bump minitest from 5.14.1 to 5.14.2
...
Bumps [minitest](https://github.com/seattlerb/minitest ) from 5.14.1 to 5.14.2.
- [Release notes](https://github.com/seattlerb/minitest/releases )
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc )
- [Commits](https://github.com/seattlerb/minitest/compare/v5.14.1...v5.14.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-09-02 11:18:48 +08:00
01600492de
FIX: Don't raise error in update username job if user has been deleted.
2020-09-02 11:17:17 +08:00
ec0b4b2acc
FIX: wait for groups before showing empty message
2020-09-01 22:36:00 -04:00
7b7357147e
FIX: add cache breaker for fonts
...
This is a temporary fix since fonts may be cached without CORS
A larger scale change needed.
Our long term solution here is to have the SCSS compilation pipeline take
care of this by introducing some SCSS var that can be consumed in the various
stylesheets.
We do not want to write a file on boot
2020-09-02 12:17:28 +10:00
d49e96c6a3
DEV: add plugin hooks for silence message parameters ( #10538 )
...
DEV: add plugin hooks for silence message parameters
Allows plugins to add, and update extra silence message params for custom
i18n vars
Allows plugins to override system messages via `message_title` and
`message_raw` parameters. We can later expose these params where necessary via event
hooks. Expose the parameter for the on user_silenced trigger.
2020-09-01 17:25:24 -07:00
f5051ec833
FIX: Allow fonts to be delivered via CDN
...
We introduced support for custom fonts which are shipped out of the `/fonts`
directory, however we did not provide a bypass in our NGINX config.
2020-09-02 10:19:19 +10:00
3b55de90e5
FIX: skip pm view action log while generating webhook payload.
...
Currently, while generating webhook payloads for a topic it's accidentally adding a personal message view log in 'system' user's history.
2020-09-02 05:40:42 +05:30
26ec4fd25b
FIX: User export category preferences on a deleted category. ( #10573 )
...
Tests from a1dd761bd97e748bff5b21d7347ff2a642409fc2 were incomplete and did not test a deleted category's category_users record.
2020-09-01 13:22:59 -07:00
899b841554
DEV: Faster SCSS refresh locally for plugins
...
Only updates the targeted stylesheet when available
2020-09-01 13:56:40 -04:00
5e66d7d082
FIX: emails.rake use authentication ( #10572 )
...
It looks like support got added for DISCOURSE_SMTP_AUTHENTICATION in Discourse, but not in this rake task (or perhaps it's always been broken?).
N.B.: I have not tested this code, but it reportedly works and looks safe to me.
https://meta.discourse.org/t/smtp-unrecognized-authentication-type-with-office-365/145830/6?u=pfaffman
2020-09-01 11:08:18 -04:00
58e17d7eab
Build(deps-dev): Bump test-prof from 0.12.0 to 0.12.1 ( #10571 )
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 0.12.0 to 0.12.1.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v0.12.0...v0.12.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-09-01 11:07:00 -04:00
a3580fa292
DEV: Show plugin versions in CI
2020-09-01 16:05:07 +01:00
90eeb8f7d9
Build(deps): Bump logster from 2.9.3 to 2.9.4 ( #10570 )
...
Bumps [logster](https://github.com/discourse/logster ) from 2.9.3 to 2.9.4.
- [Release notes](https://github.com/discourse/logster/releases )
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.9.3...v2.9.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-09-01 16:15:54 +03:00
71da5e0e27
Update translations
2020-09-01 13:02:16 +00:00
