176aa0ac7d
DEV: Import pretender instead of global server var ( #8996 )
...
* DEV: Remove server global test variable
* Delete yarn-error.log
* prettier and some eslint fixes
* add global server variable back for plugins
* rename imported server to pretender
* prettier
* support plugin server. usage
* Export pretender as named
* Prettier
* change default pretender export
* fix bad import
* Use pretender() and original default export
* export new Pretender as default
* fix accidental change
* WIP testing
* add pretend handlers in correct location
* move more stuff into the correct pretender
* Consolidated more pretenders
* comment out another bad test
* fix user acceptance tests
* commented out bad test
* fixed another composer server stub
* fix more tests
* fixed tag test pretender
* Fix admin email test
* removed another draft handler
* add back test
* fix and uncomment another test
* remove test that is not useful
* remove commented out lines
* reapply handlers between every test
* no need to re-stub requests now :)
* cleanup from review
* more cleanup
2020-03-02 14:24:31 -05:00
fedd8e3e3a
DEV: Remove uses of deprecated Ember.copy and Copyable ( #8978 )
2020-03-02 14:24:05 -05:00
76a06dfa03
DEV: Remove the last (defunct) use of Ember.View ( #8976 )
...
This codepath has been deprecated 3 years ago in c5687100b04662b3d754ed0a8ae053d6298fca26.
Ember.View has been removed in Ember 2.0.
2020-03-02 14:23:46 -05:00
f9cc3dc4b7
PERF: Allow passing an existing list of user field ids when loading ( #8970 )
...
* PERF: Allow passing an existing list of user field ids when loading
This avoids the need for running `UserField.pluck(:id)` for each user that is serialized
* Memoize user_fields to avoid rebuilding hash ever time
2020-03-02 14:22:49 -05:00
a09e5d12c2
FIX: Topics should honor auto-close when published to category ( #8963 )
...
* FIX: Topics should honor auto-close when published to category
* Add test
2020-03-02 14:21:35 -05:00
5c39e21c18
UX: Allow correct pluralization for "too few topics and posts" notices ( #8947 )
2020-03-02 14:20:37 -05:00
8e7868b405
Build(deps-dev): Bump rubocop from 0.80.0 to 0.80.1 ( #9081 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.80.0 to 0.80.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.80.0...v0.80.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-03-02 14:10:19 -05:00
93b8d7ec89
Build(deps): Bump puma from 4.3.2 to 4.3.3 ( #9079 )
...
Bumps [puma](https://github.com/puma/puma ) from 4.3.2 to 4.3.3.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v4.3.2...v4.3.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-03-02 14:09:56 -05:00
98d4b7bbc1
Build(deps-dev): Bump better_errors from 2.5.1 to 2.6.0 ( #9043 )
...
Bumps [better_errors](https://github.com/BetterErrors/better_errors ) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/BetterErrors/better_errors/releases )
- [Commits](https://github.com/BetterErrors/better_errors/compare/v2.5.1...v2.6.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-03-02 14:09:33 -05:00
d85726a866
Build(deps-dev): Bump simplecov from 0.18.3 to 0.18.5 ( #9044 )
...
Bumps [simplecov](https://github.com/colszowka/simplecov ) from 0.18.3 to 0.18.5.
- [Release notes](https://github.com/colszowka/simplecov/releases )
- [Changelog](https://github.com/colszowka/simplecov/blob/master/CHANGELOG.md )
- [Commits](https://github.com/colszowka/simplecov/compare/v0.18.3...v0.18.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-03-02 14:09:05 -05:00
ed85cfe141
FIX: prevents click on sk header to bubble ( #9084 )
2020-03-02 20:06:02 +01:00
d05142d3f7
FEATURE: Enable service worker on iOS PWA
2020-03-02 15:55:09 -03:00
5889309d3b
FIX: Restoring with disable_emails: false didn't work anymore
2020-03-02 17:44:01 +01:00
d7ccb58559
FIX: Google Groups scraper failed to login
2020-03-02 17:24:48 +01:00
fd38ed3631
DEV: Fix lint error introduced in 58f16f2
2020-03-02 13:04:52 -03:00
58f16f2e2b
FIX: Make FooterNav work with PWAs on iPadOS
2020-03-02 12:56:37 -03:00
68c7699c46
Revert "Build(deps-dev): Bump annotate from 3.0.3 to 3.1.0 ( #9013 )"
...
v3.1.0 has a bug which rewrites default annotations with erroneous quotes. https://github.com/ctran/annotate_models/issues/762
This reverts commit dd4a04e72c5bb9c37cdc44b588a76818628b524e.
2020-03-02 13:34:39 +00:00
34fddaa824
Build(deps): Bump rails_multisite from 2.0.7 to 2.1.0 ( #9083 )
...
Bumps [rails_multisite]() from 2.0.7 to 2.1.0.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-03-02 10:34:17 +00:00
8123538c94
DEV: Minor review fixes and fix bookmark spec logging ( #9045 )
...
As per:
https://review.discourse.org/t/fix-never-allow-custom-emoji-to-be-marked-secure-8965/9072
https://review.discourse.org/t/feature-improving-bookmarks-part-2-topic-bookmarking-8954/9038
2020-03-02 15:40:29 +10:00
4635be10c8
DEV: Add docker cleanup script to d/ folder
2020-03-01 12:09:07 -08:00
e23e247dff
DEV: spec suite fails on leap years
...
Something about year math fails here on leap years, just
set up the clock so it is consistent to avoid it.
2020-02-29 18:30:08 +11:00
b4999acadd
PERF: improve performance of category topic list
...
In some cases CTE caused pathologically bad query plans.
This optimises it so query runs by itself and caches for lifetime
of the topic query object.
This lightweight caching is done cause topic query will often
execute two queries (one for pinned and one for non pinned)
2020-02-29 15:40:54 +11:00
18209e1daf
DEV: remove dead code
...
This code is not called anywhere, remove it
2020-02-29 15:05:09 +11:00
18ed2cc7d8
Build(deps): Bump puma from 4.3.1 to 4.3.2 ( #9063 )
...
Bumps [puma](https://github.com/puma/puma ) from 4.3.1 to 4.3.2.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v4.3.1...v4.3.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-02-28 14:25:52 -05:00
2db8ada222
FIX: ensures category url of category drop is built using slug and id ( #9069 )
2020-02-28 17:58:22 +01:00
ff5ff8d0d2
fix invalid byte sequence in UTF-8 (ArgumentError) ( #9077 )
2020-02-28 10:26:18 -05:00
0903aa44bb
FEATURE: Always disable customizations on the /safe-mode route ( #9052 )
...
This makes it easier to enter safe mode when a customization has made the UI unusable
2020-02-28 10:53:11 +00:00
8cbb6e35cb
DEV: Fix build
...
Follow up to 60184a290c45926583393cf53895e063b4798ff5.
2020-02-28 11:31:04 +02:00
60184a290c
FIX: Sync preload key format for category topic lists
...
The server and client used two different formats for preload keys. The
server was using 'topic_list_c/SLUG/l/latest', but the client was using
'topic_list_c/SLUG/ID/l/latest'.
This commit is an addition to 374534f00ee487d859fc2b826ea519befe0da350.
2020-02-28 11:10:03 +02:00
14adddd18d
FIX: Ignore secure-media-uploads for miniprofiler ( #9070 )
2020-02-28 12:11:30 +10:00
8e5edae093
FEATURE: unconditionally skip indexing on search controller
...
There are absolutely no actions in search that need indexing
Also no point adding this header on non get requests
2020-02-28 09:21:31 +11:00
f358114361
FIX: Prettier on iframed-html component ( #9062 )
2020-02-27 11:56:13 -06:00
337b823ec6
Merge pull request from GHSA-vw39-6w7q-gfx5
...
Co-authored-by: Robin Ward <robin.ward@gmail.com >
2020-02-27 11:47:15 -06:00
87f15f9ed6
FIX: When appending tags to restricted category posts, we need to pass the category id, or it won't work. ( #9020 )
2020-02-27 14:10:14 -03:00
c9b53d5647
FIX: prevnets loading to show during debouncing ( #9060 )
...
This will also fix a bug in IE11 where click event would not be triggered on row
2020-02-27 15:20:30 +01:00
501936f0da
FIX: prevents loading to show during debouncing ( #9060 )
...
This will also fix a bug in IE11 where click event would not be triggered on row
2020-02-27 15:20:04 +01:00
4673f31c75
FIX: Bulk badge awards should work even if the CSV has nil values
2020-02-27 11:08:24 -03:00
d461772661
FIX: Skip poll tutorial if user cannot create polls ( #9058 )
2020-02-27 16:01:59 +02:00
0af2f5db64
UX: Differentiate Between PMs and Topics in Search Results ( #8933 )
...
PMs will now display an envelope icon next to the topic title in search results. This is especially useful when searching using `in:all`.
Co-authored-by: adam j hartz <hz@mit.edu >
2020-02-27 13:25:32 +00:00
56345faf9a
FIX: prevents row click event to be caught by filter input event ( #9059 )
...
This was causing some dropdowns to not work under IE11
2020-02-27 14:04:23 +01:00
60908a94ec
FIX: Skip 'invited' small action if user is in an invited group ( #9056 )
...
Inviting a user that is already invited through a group used to generate
a small action and a notification. This commit skips that small action.
2020-02-27 14:45:20 +02:00
dfe11321d8
FIX: Polyfill Promise for IE11 ( #9057 )
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com >
2020-02-27 12:13:07 +00:00
a4fc6ccc12
UX: prevents jumpyness when displaying poll voters ( #9054 )
2020-02-27 11:09:54 +01:00
acf337d583
FEATURE: auto archive group message if topic is closed. ( #9046 )
...
Co-Authored-By: Régis Hanol <regis@hanol.fr >
2020-02-27 11:09:37 +05:30
5774107a2d
FIX: downloaded image URLs incorrectly replaced in post raw. ( #9014 )
...
Previously, while replacing the downloaded image URL `http://wiki.mozilla.org/images/2/2e/Longcat1.png ` similar non-image URL `http://wiki.mozilla.org/images/2 ` was replaced wrongly.
2020-02-27 10:22:55 +05:30
9f528f0ec2
Version bump to v2.5.0.beta1
2020-02-26 16:56:11 -05:00
87b2871074
Build(deps): Bump logster from 2.6.3 to 2.7.0 ( #9050 )
...
This includes a new feature that allows you to control the length of log messages via `Logster.config.maximum_message_length`. More details at: e5c4fc0b6ehttps://github.com/discourse/logster ) from 2.6.3 to 2.7.0.
- [Release notes](https://github.com/discourse/logster/releases )
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.6.3...v2.7.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-02-26 22:08:39 +03:00
3568f296a3
FIX: Another attempt at fixing reviewable claiming
...
Follow-up to 9314751e5c7470a654d26ff6dc4724a8c85f56d0.
2020-02-26 10:46:10 +02:00
9314751e5c
FIX: Claim reviewable button did not show up for all topics
...
Follow-up to 514c22e64b8b3aa95dde0456116fad5b954df384.
2020-02-26 10:36:35 +02:00
603c56f71c
FIX: Lefthook was not excluding enough JS
2020-02-25 17:28:53 -05:00
