Commit Graph

56910 Commits

Author SHA1 Message Date
216e73eb3b Build(deps-dev): Bump rubocop from 1.69.0 to 1.69.1 (#30072) 2024-12-04 00:55:32 +01:00
aca6c462a6 DEV: Improve rspec gem backtrace exclusion ENV vars (#30056)
Followup:

* https://github.com/discourse/discourse/pull/28160
* https://github.com/discourse/discourse/pull/25921

In the previous PRs we added 2 environent variables
to control backtrace output for errors in rspec,
`RSPEC_EXCLUDE_NOISE_IN_BACKTRACE`, and
`RSPEC_EXCLUDE_GEMS_IN_BACKTRACE`

These largely do the same thing, and we want to enable
that behaviour by default.

This commit consolidates them into one env var,
`DISCOURSE_INCLUDE_GEMS_IN_RSPEC_BACKTRACE`, which is
disabled by default, meaning gem backtraces will not
be shown in rspec backtraces by default.

Also for the request spec use case with `RspecErrorTracker`,
we now show an indicator of how many lines were hidden from
the backtrace e.g. "...(21 framework line(s) excluded)",
and for this and the normal rspec backtrace exclusion we
show a warning if `DISCOURSE_INCLUDE_GEMS_IN_RSPEC_BACKTRACE`
is not enabled.
2024-12-04 09:54:11 +10:00
9541c9bf18 Build(deps-dev): Bump puppeteer-core from 23.9.0 to 23.10.0 (#30080) 2024-12-04 00:53:22 +01:00
92aff52266 Build(deps): Bump json from 2.8.2 to 2.9.0 (#30071) 2024-12-04 00:51:19 +01:00
4a7ed8b9f8 Build(deps-dev): Bump rspec-support from 3.13.1 to 3.13.2 (#30075) 2024-12-04 00:49:59 +01:00
9b87e688ef Build(deps): Bump minitest from 5.25.2 to 5.25.3 (#30074) 2024-12-04 00:48:08 +01:00
cb82d798ef Build(deps-dev): Bump webpack from 5.96.1 to 5.97.0 (#30082) 2024-12-04 00:45:25 +01:00
a5636afb08 DEV: Add posts_moved DiscourseEvent in PostMover (#30066) 2024-12-03 13:16:20 -06:00
c67d3131aa UX: adjust mobile chat text title alignment (#30065) 2024-12-03 14:11:33 -05:00
94697467af DEV: Add topic-list-item-class transformer (#30008) 2024-12-03 14:22:13 +01:00
48323230a4 FIX: Stick to then/finally in history-store (#30061)
async/await doesn't play well with transitions (to be investigated… later)
2024-12-03 14:13:26 +01:00
c3e87b5036 UX: Only add user-badge-buttons wrapper when badges exist (#30060)
Followup to 2513339955ebdfa457a5d6126716091110045e37
2024-12-03 13:12:44 +00:00
9389bf295c DEV: Make history-store work in non-accceptance tests (#30059) 2024-12-03 13:32:37 +01:00
685dc4b9b9 FIX: font awesome remapping migration should not drop unmapped names from svg_icon_subset (#30058)
* FIX: font awesome remapping migration should not drop unmapped names
2024-12-03 18:30:08 +08:00
f6df8832e2 UX: Update allow_index_in_robots_txt site setting description (#29901)
Update indexing site setting description to more adequately warn about the dangers of making changes
2024-12-03 11:17:13 +01:00
783a162e9e Build(deps): Bump webrick from 1.9.0 to 1.9.1
Bumps [webrick](https://github.com/ruby/webrick) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/ruby/webrick/releases)
- [Commits](https://github.com/ruby/webrick/compare/v1.9.0...v1.9.1)

---
updated-dependencies:
- dependency-name: webrick
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-03 10:44:05 +01:00
806e37aaec FIX: better edit conflict handling (#29789)
* FIX: better edit conflict handling

Properly keep track of the original title and tags when dealing with edit conflicts.

Internal ref - t/141218
2024-12-03 10:12:04 +01:00
89a6cac968 FIX: attempt to simplify chat navbar spacing (#30054)
The main bug this commit is fixing is lack of spacing on the title "channels" when visiting the chat homepage on mobile.
2024-12-03 09:33:10 +01:00
ef9d7579df UX: Add admin filter row styling (#30057)
* DEV: add scss file for admin filter

* UX: apply styling for the filter row
2024-12-03 18:22:13 +11:00
2513339955 FEATURE: Show when a badge has been granted for a post (#29696)
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2024-12-03 13:43:27 +11:00
435fbb7408 DEV: unsilence deprecation warning for old Font Awesome icons (#30028)
* DEV: unsilence deprecation warnings for old Font Awesome icon names

* update fa-user to user font awesome icon name
* update pencil-alt to pencil font awesome 6 icon name
2024-12-03 10:28:39 +08:00
996f56d005 Build(deps-dev): Bump json-schema from 5.1.0 to 5.1.1 (#30052)
Bumps [json-schema](https://github.com/voxpupuli/json-schema) from 5.1.0 to 5.1.1.
- [Changelog](https://github.com/voxpupuli/json-schema/blob/master/CHANGELOG.md)
- [Commits](https://github.com/voxpupuli/json-schema/compare/v5.1.0...v5.1.1)

---
updated-dependencies:
- dependency-name: json-schema
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-03 00:13:44 +01:00
043af41c5b Build(deps): Bump net-http from 0.5.0 to 0.6.0 (#30051)
Bumps [net-http](https://github.com/ruby/net-http) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/ruby/net-http/releases)
- [Commits](https://github.com/ruby/net-http/compare/v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: net-http
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-03 00:01:56 +01:00
83719f2229 Build(deps): Bump securerandom from 0.3.2 to 0.4.0 (#30049)
Bumps [securerandom](https://github.com/ruby/securerandom) from 0.3.2 to 0.4.0.
- [Release notes](https://github.com/ruby/securerandom/releases)
- [Commits](https://github.com/ruby/securerandom/compare/v0.3.2...v0.4.0)

---
updated-dependencies:
- dependency-name: securerandom
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-03 00:01:34 +01:00
f2e4deb7da Build(deps): Bump logger from 1.6.1 to 1.6.2 (#30048)
Bumps [logger](https://github.com/ruby/logger) from 1.6.1 to 1.6.2.
- [Release notes](https://github.com/ruby/logger/releases)
- [Commits](https://github.com/ruby/logger/compare/v1.6.1...v1.6.2)

---
updated-dependencies:
- dependency-name: logger
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-03 00:01:26 +01:00
26fa739152 Build(deps): Bump rails-html-sanitizer from 1.6.0 to 1.6.1 (#30043)
Bumps [rails-html-sanitizer](https://github.com/rails/rails-html-sanitizer) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/rails/rails-html-sanitizer/releases)
- [Changelog](https://github.com/rails/rails-html-sanitizer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rails/rails-html-sanitizer/compare/v1.6.0...v1.6.1)

---
updated-dependencies:
- dependency-name: rails-html-sanitizer
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-03 00:01:15 +01:00
c882f8eab8 Build(deps): Bump psych from 5.2.0 to 5.2.1 (#30046)
Bumps [psych](https://github.com/ruby/psych) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/ruby/psych/releases)
- [Commits](https://github.com/ruby/psych/compare/v5.2.0...v5.2.1)

---
updated-dependencies:
- dependency-name: psych
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 23:39:12 +01:00
1f3291eb41 Build(deps): Bump date from 3.4.0 to 3.4.1 (#30044)
Bumps [date](https://github.com/ruby/date) from 3.4.0 to 3.4.1.
- [Release notes](https://github.com/ruby/date/releases)
- [Commits](https://github.com/ruby/date/compare/v3.4.0...v3.4.1)

---
updated-dependencies:
- dependency-name: date
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 23:39:02 +01:00
8c113e9b5f Build(deps): Bump nokogiri from 1.16.7 to 1.16.8 (#30045)
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.7 to 1.16.8.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.16.7...v1.16.8)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 23:38:50 +01:00
c70816611f DEV: Allow webp images to be served directly by nginx (#30050)
This fixes a typo that was introduced in baa5389a237525514708a17dfa3c6b7012828dcb
2024-12-03 06:26:13 +08:00
98ba5f2dfa FEATURE: Add plugin outlets to parent category row for desktop (#30002)
* FEATURE: Add plugin outlets to parent category row

Added 3 plugin outlets:

- `category-list-above-category-section` (above `td.category`)
- `category-list-above-topics-section` (above `td.topics`)
- `category-list-below-topics-section` (below `td.topics`)

* DEV: Add value transformer for changing classes in parent category row.

renamed connectors and added connector for mobile view

* DEV: order transformers by name
2024-12-02 18:27:30 -03:00
85691a7f31 DEV: refactor composer-editor/d-editor, a little more (#29973)
Adds setupEditor to ComposerEditor so it can setup/destroy events when the underlying editorComponent is switched.

Moves putCursorAtEnd uses (which implementation is textarea-specific) to TextareaTextManipulation.

Moves insertCurrentTime and a corresponding test, which is discourse-local-dates specific, to the plugin.

Moves applyList and formatCode from DEditor to the TextareaTextManipulation.

Moves DEditor._applySurround to TextareaTextManipulation.applySurroundSelection

Avoids resetting the textarea value on applyList and formatCode, keeping the undo history.
2024-12-02 18:24:14 -03:00
706987ce76 FIX: Rate limiting when moving posts with freeze option (#30041)
before this commit, when moving posts with freeze option, the rate limit was being applied leading to errors. This commit fixes that.

and also adds tests for the scenarios of moving posts with freeze option.
2024-12-02 15:48:13 -03:00
7750441c43 DEV: Correct ember-template-lint commands (again) (#30038)
This was fixed in 5563e9dc03bc465ee484dcf2c07b1a1bf989ef79, but then regressed again by an unintentional change in 6f7c581a8066f19956ad43431333292243b2c72b
2024-12-02 18:13:40 +00:00
b47ae6d437 UX: Strip multiline comments in github oneboxes (#30040)
We were already stripping comments from GitHub issue/PR oneboxes, but the regex was not correctly matching multiline comments.
2024-12-02 18:08:55 +00:00
31dadc8373 DEV: Add plugin wrappers required to fix template overrides (#29825)
* DEV: Add plugin wrappers required to fix tempalte overrides

* updated search-result-entry file

* activity file unintended changes fixed
2024-12-02 13:07:27 -05:00
cf2b4d9934 DEV: Apply new Rubocop linting on services 2024-12-02 17:31:36 +01:00
a52b83333e DEV: Correctly lint bundled plugins admin directory (#29999) 2024-12-02 16:31:21 +00:00
3b334f54fc FIX: adjust codeblock link styling (#30036) 2024-12-02 09:49:54 -06:00
cb663b89cc FIX: Virtual keyboard for fullpage login/signup (#29543)
This change allows the form to resize when the virtual keyboard is shown on Chrome/Android
2024-12-02 12:33:51 -03:00
72f3cd252f DEV: Use new qunit-dom's includesValue/doesNotIncludeValue (#30034) 2024-12-02 16:30:56 +01:00
9bdd97db42 FIX: editing post while replying (#29985)
BEFORE: if you click the "reply" button on a post and then decided that you want to "edit" the same post, clicking the "edit" button would do nothing. Clicking "edit" on another post works, but editing the same post would appear broken.

AFTER: if you click the "edit" button, it will properly load the content of the post you're trying to edit. No matter which one it is.

This was somewhat tricky to track down as the system specs seemed to contradict the qunit tests until I realized that the qunit tests were only testing the edit on the 1st post and the system specs were testing on replies.

I improved the qunit tests to test both editing OP and a reply and (hopefully) made the system specs a little bit clearer.

This is a follow up to bbe62d88d2554189e15f407736b1f7a01968c631.
2024-12-02 16:06:36 +01:00
ab32623c07 UX: disable scrolling when modal is open on desktop (#30035)
Uses the `htmlClass` to automagically set the `modal-open` class to
`<html>` so that we can do `overflow: hidden` and prevent the
"background" behind the modal from scrolling while the modal is open.

Internal ref - t/142760
2024-12-02 15:08:43 +01:00
5d5f9ecfb9 Build(deps-dev): Bump lefthook from 1.8.4 to 1.8.5 (#30031)
Bumps [lefthook](https://github.com/evilmartians/lefthook) from 1.8.4 to 1.8.5.
- [Release notes](https://github.com/evilmartians/lefthook/releases)
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md)
- [Commits](https://github.com/evilmartians/lefthook/compare/v1.8.4...v1.8.5)

---
updated-dependencies:
- dependency-name: lefthook
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 14:07:27 +01:00
62fc2a383a Build(deps): Bump @glimmer/syntax from 0.92.3 to 0.93.1 (#30032)
Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm) from 0.92.3 to 0.93.1.
- [Release notes](https://github.com/glimmerjs/glimmer-vm/releases)
- [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/main/CHANGELOG.md)
- [Commits](https://github.com/glimmerjs/glimmer-vm/commits)

---
updated-dependencies:
- dependency-name: "@glimmer/syntax"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 12:19:33 +00:00
08542400ad Build(deps-dev): Bump jsuites from 5.7.2 to 5.8.0 (#30033)
Bumps [jsuites](https://github.com/jsuites/jsuites) from 5.7.2 to 5.8.0.
- [Release notes](https://github.com/jsuites/jsuites/releases)
- [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md)
- [Commits](https://github.com/jsuites/jsuites/commits)

---
updated-dependencies:
- dependency-name: jsuites
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 12:18:52 +00:00
7d5d1dcc51 Build(deps-dev): Bump qunit-dom from 3.3.0 to 3.4.0 (#30030) 2024-12-02 13:18:28 +01:00
33ef912dc5 Build(deps-dev): Bump lint-to-the-future from 2.4.1 to 2.5.1 (#30029)
Bumps [lint-to-the-future](https://github.com/mansona/lint-to-the-future) from 2.4.1 to 2.5.1.
- [Release notes](https://github.com/mansona/lint-to-the-future/releases)
- [Changelog](https://github.com/mansona/lint-to-the-future/blob/main/CHANGELOG.md)
- [Commits](https://github.com/mansona/lint-to-the-future/commits)

---
updated-dependencies:
- dependency-name: lint-to-the-future
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 12:18:18 +00:00
5af056c48c DEV: Set version on tracked-built-ins patch (#30024) 2024-12-02 10:10:59 +01:00
44a81069ac DEV: Avoid creating system message when system user initiates restore (#30027)
There is no point creating a message for the system user since it is a
non-human user.
2024-12-02 16:13:38 +08:00