2f03a879f9
DEV: Require rails_failover before global settings.
2020-05-20 16:06:40 +08:00
f7f436e536
DEV: Install rails_failover gem to test our Redis changes.
2020-05-20 15:40:27 +08:00
30bbc485d0
DEV: remove superfluous comment
2020-05-20 16:53:48 +10:00
e97cb20c2a
UX: strip text from PM bookmark and share buttons
...
Also organize priorities in an easier to reason about way and
shift bookmark topic so it is after link. (consistent with posts)
2020-05-20 16:46:49 +10:00
b031e3220a
FIX: migrations should not fail when db is part migrated
...
When part migrated the translate overrides may have missing columns
in that case just silently ignore overrides
2020-05-20 15:28:01 +10:00
05f7d5a2de
UX: Rename "Edit Message" to "Edit"
...
This reduces the space taken by the button.
2020-05-20 14:12:58 +10:00
37983a7815
Fix lint.
2020-05-20 10:33:34 +08:00
b7387d4611
DEV: Remove code unused code when seeding narrative bot.
2020-05-20 10:22:51 +08:00
234cd5c3e7
FIX: Switch discobot to pull avatar from gravatar.
2020-05-20 10:20:08 +08:00
6b92c78033
FIX: purge all associated data on user delete
...
This commit reorganises the delete dependencies on users and make sure
all are covered. We forgot some on bookmarks, security keys, anon users
and so on.
2020-05-20 11:27:57 +10:00
a93d0a8fcc
UX: Remove bold from category badge text
2020-05-19 21:11:49 -04:00
e334133294
PERF: Remove foreign keys from bookmarks ( #9837 )
...
As a general rule we do not add FKs in Discourse and instead rely on consistency checks at weekly/daily intervals
2020-05-20 10:45:49 +10:00
72f139191e
FIX: S3 store has_been_uploaded? was not taking into account s3 bucket path ( #9810 )
...
In some cases, between Discourse forums the hostname of a URL could match if they are hosting S3 files on the same bucket but the S3 bucket path might not. So e.g. https://testbucket.somesite.com/testpath/some/file/url.png vs https://testbucket.somesite.com/prodpath/some/file/url.png . So has_been_uploaded? was returning true for the second URL, even though it may have been uploaded on a different Discourse forum.
This is a very rare case but must be accounted for, because this impacts UrlHelper.is_local which mistakenly thinks the file has already been downloaded and thus allows the URL to be cooked, where we want to return the full URL to be downloaded using PullHotlinkedImages.
2020-05-20 10:40:38 +10:00
0a700d81fc
FIX: Restoring backups could fail for database dumps > 8GiB
...
This is a temporary fix until we ship a new image with bsdtar.
2020-05-19 22:36:59 +02:00
52228b1fa6
DEV: These routes don't exist anymore ( #9823 )
2020-05-19 16:09:03 -03:00
a239900522
UI: reduces category row description margin ( #9834 )
2020-05-19 20:44:54 +02:00
05d8091bd3
DEV: adds triggerOnChangeOnTab option to select-kit ( #9833 )
...
Usage:
```
options=(hash triggerOnChangeOnTab=false)
```
This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
42229fecad
Build(deps): Bump rbtrace from 0.4.12 to 0.4.13 ( #9827 )
...
Bumps [rbtrace](https://github.com/tmm1/rbtrace ) from 0.4.12 to 0.4.13.
- [Release notes](https://github.com/tmm1/rbtrace/releases )
- [Commits](https://github.com/tmm1/rbtrace/compare/v0.4.12...v0.4.13 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-19 12:46:16 -04:00
b23fe547ab
Build(deps): Bump puma from 4.3.3 to 4.3.4 ( #9824 )
...
Bumps [puma](https://github.com/puma/puma ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v4.3.3...v4.3.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-19 12:40:39 -04:00
01c27d991a
Build(deps-dev): Bump minitest from 5.14.0 to 5.14.1 ( #9807 )
...
Bumps [minitest](https://github.com/seattlerb/minitest ) from 5.14.0 to 5.14.1.
- [Release notes](https://github.com/seattlerb/minitest/releases )
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc )
- [Commits](https://github.com/seattlerb/minitest/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-19 11:34:53 -04:00
ab6737c44a
UX: improves topic-notifications-button loading behavior ( #9832 )
2020-05-19 17:13:40 +02:00
38c05a4f07
FIX: Check backtrace and backtrace_locations before trying to print an error
...
... during plugin initialization.
2020-05-19 14:27:22 +01:00
f038f8f154
FIX: description for 'uncategorized' category was blank
2020-05-19 18:45:43 +05:30
b4c5ff17a3
FIX: Show a useful message when starting a plugin fails without a backtrace
2020-05-19 14:03:54 +01:00
7c3663ff73
UX: adds visual feedback when changing topic notifications level ( #9831 )
2020-05-19 13:27:57 +02:00
05ca0c908f
FIX: GroupArchivedMessage belongs to Group, not User
2020-05-19 14:13:28 +03:00
e9f579bd3f
DEV: Clean up thumbnail tests correctly
2020-05-19 11:04:02 +01:00
725e38f9d7
DEV: Allow plugins to request topic thumbnail sizes ( #9828 )
...
In plugin.rb, you can register new sizes like
```
register_topic_thumbnail_size [512, 512]
```
For more information about thumbnails see 03818e642a
2020-05-19 10:38:58 +01:00
f2574736a2
FEATURE: Add same site cookie 'None' option to make cross domain systems possible ( #9374 )
...
Previously reverted in cb8f8de4, but can be re-applied now that Rack has been updated
2020-05-19 10:33:46 +01:00
1647ba4624
FIX: applies flex on topic-footer-main-buttons ( #9829 )
2020-05-19 11:29:38 +02:00
7b7c0ef52f
DEV: removes brittle test ( #9826 )
2020-05-19 10:02:40 +02:00
3623a395dc
UI: refinements to topic footer buttons ( #9780 )
2020-05-19 09:51:34 +02:00
779dc30d2e
FIX: Join bookmarks migration on users to avoid missing user records
...
* the post_actions table has no FK to users, so if a user has been
deleted we may end up with dangling post_action records, which then
interferes with the bookmarks migration because bookmarks DO have
an FK to users
2020-05-19 16:31:05 +10:00
062cb1e1cb
UX: Remove caret from notifications-button.
2020-05-19 13:41:13 +08:00
864fb45ff0
Improve mobile friendliness of crawler view
2020-05-19 00:24:17 -04:00
05beaa7f45
DEV: Remove override of flushdb in DiscourseRedis.
2020-05-19 10:26:23 +08:00
96c02caba7
DEV: Change use of Redis flushall to flushdb.
...
FLUSHALL removes all keys from all databases. Instead we only want to
remove keys from the current Redis database.
2020-05-19 10:20:00 +08:00
f99f6ca111
FIX: randomize file name when created from fixtures ( #9731 )
...
* FIX: randomize file name when created from fixtures
When a temporary file is created from fixtures it should have a unique name.
It is to prevent a collision in parallel specs evaluation
* FIX: use /tmp/pid folder to keep fixture files
2020-05-19 09:09:36 +10:00
16f6240782
FIX: Bump rack version from 2.0.8 to 2.2.2 ( #9811 )
...
Version 2.1.1 was not working with our Sidekiq but version 2.2.2 is fine
2020-05-19 08:43:45 +10:00
6d5e9db883
FIX: Restoring backup didn't clear cached translation overrides
2020-05-18 18:51:51 +02:00
27c611b1d1
FIX: Reverting multiple translation overrides didn't clear cache
2020-05-18 18:51:29 +02:00
cfad38184d
FIX: improves and fixes a regression with category-selector ( #9821 )
2020-05-18 17:44:47 +02:00
96848b7649
UX: Allow secure media URLs to be cached for a short period of time
...
Signed S3 URLs are valid for 15 seconds, so we can safely allow the browser to cache them for 10 seconds. This should help with large numbers of requests when composing a post with many images.
2020-05-18 15:00:41 +01:00
303dece5ee
DEV: skip this test for now ( #9818 )
...
It seems to be involved in various random failures
2020-05-18 15:37:58 +02:00
1876b3cc4c
FIX: more resilient/consistent date-picker loading ( #9817 )
2020-05-18 15:29:24 +02:00
48ed1b40cf
REFACTOR: ensures later is correctly canceled ( #9796 )
2020-05-18 14:20:23 +02:00
9482ddff73
UX: show caret only in topic footer buttons dropdown select boxes ( #9816 )
2020-05-18 14:07:40 +02:00
f968155288
FIX: Ensure no image downloads during topic thumbnail serialization
...
If image uploads are missing a width/height, we re-download them to update the width/height in the database. However, this takes significant resources so we don't want to run this logic during topic serialization.
2020-05-18 12:04:29 +01:00
918bd75909
FIX: allows to remove a topic timer with delete_replies as type ( #9800 )
2020-05-18 11:47:08 +02:00
d01c336899
DEV: Clean up some Redis leaks in test env.
2020-05-18 17:27:37 +08:00
