Commit Graph

33309 Commits

Author SHA1 Message Date
468cfa39f7 REFACTOR: rename-tag controller (#7634) 2019-05-29 15:58:12 +02:00
f2858e03c8 REFACTOR: preferences/email controller (#7633) 2019-05-29 15:53:42 +02:00
5e7e32510a FIX: lookup should be done against locale of reference (#7632) 2019-05-29 15:45:44 +02:00
05206a61ab FIX: displays text of asset-version changed modal (#7631) 2019-05-29 15:38:14 +02:00
20e783337d DEV: Remove use of fake external store in optimized images spec.
Testing against fake stuff is bad because we're not testing against reality when
reality changes.
2019-05-29 20:13:23 +08:00
630e9814bc datetime is not available at this point (#7630) 2019-05-29 14:06:32 +02:00
6439004161 DEV: do not use STDERR to print tests timestamps (#7629) 2019-05-29 13:28:02 +02:00
8d1b0224ac Fix the build a3938f98f8b575675fc9b541725aa224fcddf682. 2019-05-29 18:53:31 +08:00
a3938f98f8 Revert changes to FileStore::S3Store#path_for in f0620e7118a76a1faea0ca15ac554818f8bb1bcf.
There are some places in the code base that assumes the method should
return nil.
2019-05-29 18:39:07 +08:00
5d47d1833b DEV: prints timestamp at every docker:test commands (#7628) 2019-05-29 12:20:33 +02:00
c920f9d137 FIX: Have nginx always pass /uploads/short-url requests to app.
Follow up to f0620e7118a76a1faea0ca15ac554818f8bb1bcf
2019-05-29 18:19:15 +08:00
6be9a6eb2e DEV: adds time logging to docker_test script (#7627) 2019-05-29 12:06:43 +02:00
e12ae453e9 FIX: verify the exitence of s3_object properly without db name 2019-05-29 15:10:36 +05:30
9a9a06e34b DEV: add option to skip etag verification on 'migrate_to_s3' rake task 2019-05-29 14:16:36 +05:30
b114bcd294 DEV: switch message bus backend to memory for tests
This backend is a bit faster and well tested, this is part of a longer
term plan to have a `backend: :memory, threaded: false` type config for
message bus which we can use in test.

The threading in message bus causes all sorts of surprises in test, it will
be nice not to be beholden to them.
2019-05-29 16:34:55 +10:00
1efed6e527 DEV: amend test for anonymous handling to use real data
Previously we relied on fabrication on anonymous, we can not get the
transaction commit pipeline to work as it does in production, cleanly

This amends it so our anonymous user is created using the core APIs

Signed-off-by: Sam Saffron <sam.saffron@gmail.com>
2019-05-29 15:05:37 +10:00
04fdada96a annotate models 2019-05-29 14:26:24 +10:00
5c524ea8a4 FEATURE: introduce dedicated storage and DB constraints for anon users
Previously we used custom fields to denote a user was anonymous, this was
risky in that custom fields are prone to race conditions and are not
properly dedicated, missing constraints and so on.

The new table `anonymous_users` is properly protected. There is only one
possible shadow account per user, which is enforced using a constraint.

Every anonymous user will have a unique row in the new table.
2019-05-29 14:26:24 +10:00
a206da8e18 DEV: Mark discourse-encrypt plugin as official. 2019-05-29 10:20:46 +08:00
f0620e7118 FEATURE: Support [description|attachment](upload://<short-sha>) in MD take 2.
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
63292cecd9 PERF: Prefer joins over IN () queries. 2019-05-29 09:00:15 +08:00
76569b2018 FIX: ensures post-small-action is using timezone to display dates 2019-05-29 08:45:28 +08:00
3a1d99577e FIX: Replace details content with instruction. 2019-05-29 08:36:04 +08:00
6cceb72173 DEV: Reduce verbosity in TopicQuery spec. 2019-05-29 08:32:10 +08:00
a93aa5bbce Add "further reading for themes" step to wizard 2019-05-29 08:28:03 +08:00
43e33302e1 FIX: Position emoji-picker around d-editor. 2019-05-29 08:27:14 +08:00
7a08e23b4b FIX: Bump search index version. 2019-05-29 08:20:59 +08:00
7c9fb95c15 Temporarily revert "FEATURE: Support [description|attachment](upload://<short-sha>) in MD. (#7603)"
This reverts commit b1d3c678ca39cf7f09ac3eb257c7153d4863a2a9.

We need to make sure post_upload records are correctly stored.
2019-05-28 16:37:01 -04:00
f3c07e27d9 FIX: correct translations for logs error rate notice (#7622)
The problem here is that hour and minute were passed to the %{duration} variable which made them impossible to translate in other languages.

I wonder if it's worth having 2 almost identical translations just for "reached" and "exceeded"? Perhaps we could combine them in one copy?
2019-05-28 22:10:51 +03:00
91ff8684fd FIX: Use the right property for post ID. 2019-05-28 22:00:58 +03:00
67d8ceedf1 Remove unused variable 2019-05-28 14:31:52 -04:00
c57ab12238 UX: Move preview button to bottom right of mobile composer 2019-05-28 14:19:33 -04:00
7a7d612b23 DEV: skips tests being the possible source of timeouts (#7623) 2019-05-28 20:16:42 +02:00
b3779dc377 DEV: rename 'uploads:missing' rake task into 'uploads:missing_files'.
To improve the readability.
2019-05-28 23:30:43 +05:30
bc14452585 FIX: ensures events have access to correct context (#7621) 2019-05-28 19:40:28 +02:00
b1d3c678ca FEATURE: Support [description|attachment](upload://<short-sha>) in MD. (#7603) 2019-05-28 11:18:21 -04:00
42818b810e Better handling of custom SVG sprites in themes when using S3 2019-05-28 10:58:19 -04:00
9bdfaa195e FIX: We shouldn't memoize the last time something is read 2019-05-28 10:51:18 -04:00
bed3560d61 EXPERIMENTAL: more js tests logs (#7620) 2019-05-28 14:49:45 +02:00
bf3c781f26 Bump onebox version.
- add frozen string literal to all the files
2019-05-28 17:39:42 +05:30
2e3b74c353 fix the build 2019-05-28 16:47:01 +05:30
028121b95b FIX: delete system generated message when user_export record is deleted (#7595)
FIX: system generated message for user export should be closed by default
2019-05-28 16:38:41 +05:30
6decdfce5c DEV: reduces memory footprint of tests - step 1 (#7591) 2019-05-28 12:15:12 +02:00
07b80d491b FIX: Refresh automatic groups after inviting moderators. 2019-05-28 17:19:34 +08:00
04abf18194 Fixed typo in S3 rake task 2019-05-28 16:57:55 +08:00
03e98164cb copyedit, remove needless colons 2019-05-28 00:15:47 -07:00
3d2c3bd478 FIX: username suggester incorrectly skipping over whitelisted username
SSO uses a special param to username suggester that whitelists a username
due to previous work we amended our lookup logic and started ignoring this
whitelist.

The fix ensures we always respect it, and also improves on the original
implementation that forgot to normalize the username.
2019-05-28 16:48:46 +10:00
0d9fdbf8fe FEATURE: Allow import of hidden site settings (#7601)
* Allow optional import of hidden site settings

* Always import hidden settings
2019-05-28 16:20:18 +10:00
315a38e0e3 FEATURE: Allow running message_bus in a different redis instance (#7616)
Adds `DISCOURSE_MESSAGE_BUS_REDIS_ENABLED` env var, that when set
to true, will allow Discourse to connect to a different redis
instance for MessageBus needs.

When enabled you can configure the same env vars user for redis,
but prefixed by `MESSAGE_BUS`, eg:

`DISCOURSE_MESSAGE_BUS_REDIS_HOST`
2019-05-28 15:52:43 +10:00
9a232e1a0a FEATURE: use GIVE_UP=1 to inform rake posts:missing_uploads you are done
We need this give up for cases where uploads can not be recovered

This also improves the recovery routines
2019-05-28 14:44:59 +10:00