Commit Graph

37333 Commits

Author SHA1 Message Date
4a74f18e95 PERF: Move fetching of avatar into hijack for discobot certificate 2020-05-11 09:35:06 +08:00
676be3a853 FEATURE: add no_index header if robots is disabled
Expand SiteSetting.allow_index_in_robots_txt so it also adds a
noindex header if set to false.

This makes sure that nothing is indexed even if it somehow reaches
Google.
2020-05-11 11:07:21 +10:00
12d4d51d81 FIX: CurrentUser now must be passed to resolveTimezone and user card local time issues (#9734)
* This is to prevent user's timezones being changed accidentally
e.g. by admin looking at a user
* This problem only occurred via the user card, however the user card
was still calling userTimezone even if the setting to display user
time in card was disabled
2020-05-11 11:01:47 +10:00
44712c5f98 FIX: ESC to dismiss empty draft topic composer
Previously originalTitle was set to undefined leading to
titleDirty being unconditionally undefined for new topics

That mean you could not dismiss the composer via ESC
2020-05-11 10:04:38 +10:00
8f5a651e51 DEV: No need for double await 2020-05-10 19:54:07 +02:00
09caf614de DEV: Fix build
Rails.logger is not available when Discourse.deprecate is called from
enabled_site_setting_filter.

Follow up to db4601823546b7a1451b82a6f556a30a55166a21.
2020-05-10 15:06:39 +03:00
8149bfbaf1 FEATURE: Filter settings by plugin (#9692) 2020-05-10 14:07:45 +03:00
3b2b635e9b DEV: removes setInterval as it might cause issues (#9722) 2020-05-10 08:57:48 +02:00
862d153f54 REFACTOR: removes dead code (#9721) 2020-05-09 11:50:47 +02:00
9bf11a8c68 DEV: allows select-kit to prevent autofocus of header after onChange (#9718) 2020-05-09 10:26:23 +02:00
d653d2f5d9 UX: Prevent timeline overlapping topic footer buttons 2020-05-08 16:20:27 -04:00
34e5f807ec DEV: User UPPER_CASE for constants 2020-05-08 15:50:55 -04:00
da561a430d DEV: Add data-name to popular-theme-item rows (#9714) 2020-05-08 14:38:41 -05:00
564e8566d7 SECURITY: updates juqery to 3.5.0 (#9708)
https://github.com/advisories/GHSA-gxr4-xjj5-5px2
2020-05-08 21:12:04 +02:00
5bac2828ee DEV: 25ms was too short and causing test failures (#9712) 2020-05-08 21:10:52 +02:00
b2e4ca968b DEV: Remove translate API from plugin.
It appears to be completely unused at this point.
2020-05-08 14:14:01 -04:00
7f373e8b93 DEV: Don't use js.erb for constants
Adds a new rake task to auto generate a constants.js file with the
constants present. This makes migrating to Ember CLI easier, but also
slightly speeds up asset compilation by having to do less work.

If the constants change you need to run:
`rake javascripts:update_constants`
2020-05-08 14:14:01 -04:00
dae29afd7d Build(deps): Bump jquery-rails from 4.3.5 to 4.4.0 (#9709)
Bumps [jquery-rails](https://github.com/rails/jquery-rails) from 4.3.5 to 4.4.0.
- [Release notes](https://github.com/rails/jquery-rails/releases)
- [Changelog](https://github.com/rails/jquery-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rails/jquery-rails/compare/v4.3.5...v4.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-08 13:50:56 -04:00
47788da706 FIX: Bookmark Modal Input (#9707) 2020-05-08 17:47:01 +02:00
3cce1b4e78 FIX: Support transpiling js in plugins with a root admin folder 2020-05-08 11:10:54 -04:00
a40649409e DEV: calling preload-store is deprecated (#9703) 2020-05-08 17:04:28 +02:00
350fe932ca DEV: removes setTimeout and reduces timer in tests (#9701) 2020-05-08 16:46:24 +02:00
646bee2efe DEV: removes a setTimeout and ensure shorcut is not propagated (#9702) 2020-05-08 16:46:13 +02:00
e46bf15407 FIX: some adjustment for the UI of the table 2020-05-08 16:39:31 +02:00
704e4b9cf8 DOCS: Update community install info
Update pricing as per https://www.literatecomputing.com/discourse-installation-packages (same url)
2020-05-08 18:38:29 +05:30
8d3900c6da DEV: gear icon is deprecated in favor of cog (#9704) 2020-05-08 10:35:29 +02:00
00a038d646 REFACTOR: removes various assignments and superfluous params (#9699) 2020-05-08 09:19:48 +02:00
9d172eeaa5 REFACTOR: removes implicit operand conversion (#9700) 2020-05-08 09:19:36 +02:00
6359a5f8a9 DEV: Fix poll plugin causing error when server reloads in dev env. 2020-05-08 14:59:55 +08:00
d8d54a92f1 FEATURE: tighten rate limiting rules for forgot password
1. Total 6 attempts per day per user
2. Total of 5 per unique email/login that is not found per hour
3. If an admin blocks an IP that IP can not request a reset
2020-05-08 13:30:51 +10:00
1840023c28 UX: Improve banner & alert close button alignment and consistency 2020-05-07 22:57:52 -04:00
609e929186 Revert "Revert "DEV: upgrade to Rails 6.0.3""
This reverts commit 2ff8b4f5d9dd72a55d7ebdc23a3758dd5ec4682d.

Attempt #2 at a Rails update this time we also update the
rails_multisite gem to allow for cleaner reordering
2020-05-08 11:49:22 +10:00
efd0e4d02b FIX: Don't trigger user_updated event for bot users. 2020-05-08 09:28:16 +08:00
a3e1e9ef16 FIX: remove deprecated URI.escape (#9697)
During Nokogumbo changes I introduced back URI.escape which is deprecated.
2020-05-08 11:14:59 +10:00
22dffe6f69 FIX: Do not allow null options for bookmark manager 2020-05-08 15:24:59 +00:00
e83dc75238 FIX: Migration to set column NOT NULL for delete_when_reminder_sent on bookmarks (#9696)
Also fix typo in original migration.

Meta: https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542/152?u=mjrbrennan
2020-05-08 10:43:23 +10:00
ef94b0f1a7 FIX: Incorrect CSS class 2020-05-07 16:29:09 -04:00
94d10b46ca Admin popup menu needs a higher z-index than the bg cloak on mobile 2020-05-07 16:24:47 -04:00
f9608c0af5 DEV: Remove INLINE_ONEBOX_* constants
There were two constants here, `INLINE_ONEBOX_LOADING_CSS_CLASS` and
`INLINE_ONEBOX_CSS_CLASS` that were both longer than the strings they
were DRYing up: `inline-onebox-loading` and `inline-onebox`

I normally appreciate constants, but in this case it meant that we had
a lot of JS imports resulting in many more lines of code (and CPU cycles
spent figuring them out.)

It also meant we had an `.erb` file and had to invoke Ruby to create the
JS file, which meant the app was harder to port to Ember CLI.

I removed the constants. It's less DRY but faster and simpler, and
arguably the loss of DRYness is not significant as you can still search
for the `inline-onebox-loading` and `inline-onebox` strings easily if
you are refactoring.
2020-05-07 16:14:38 -04:00
3567a90661 DEV: Ember Addon needs a vendor dir 2020-05-07 15:45:35 -04:00
744bbf6904 FEATURE: exclude muted categories from the "top" topics list. 2020-05-08 00:34:53 +05:30
4891276742 Reduce the width of the input field on desktop 2020-05-07 20:36:36 +02:00
788e305469 FIX: parenthesis were wrong, resulting in an always true expression (#9690) 2020-05-07 19:56:35 +02:00
79c64eaeff DEV: Move pretty-text into an ember-addon format (#9689) 2020-05-07 12:37:47 -04:00
781e3f5e10 DEV: Use response.parsed_body in specs (#9615)
Most of it was autofixed with rubocop-discourse 2.1.1.
2020-05-07 17:04:12 +02:00
69ef0da4c2 FIX: preload-store was removed 2020-05-07 11:00:47 -04:00
3cd412ae02 REFACTOR: removes useless variable assignment (#9666) 2020-05-07 16:41:26 +02:00
1dd9df9cd0 REFACTOR: removes overwritten properties and duplicates fn (#9686) 2020-05-07 16:39:53 +02:00
265baa40c6 REFACTOR: useless conditional as 'data' always evaluates to true (#9685) 2020-05-07 16:38:38 +02:00
99c3ce03cb REFACTOR: removes superfluous argument (#9684)
hideTooltip doesnt accept any argument
2020-05-07 16:38:23 +02:00