766bcbc684
FIX: Add editing user ids to ChatMessage and ChatMessageRevision ( #18877 )
...
This commit adds last_editor_id to ChatMessage for parity with Post in
core, as well as adding user_id to the ChatMessageRevision record since
we need to know who is making edits and revisions to messages, in case
in future we want to allow more than just the current user to edit chat
messages. The backfill for data here simply uses the record's creating
user ID, but in future if we allow other people to edit the messages it
will use their ID.
2022-11-07 09:04:47 +10:00
5a7b478fee
Build(deps): Bump zeitwerk from 2.6.4 to 2.6.5 ( #18896 )
...
Bumps [zeitwerk](https://github.com/fxn/zeitwerk ) from 2.6.4 to 2.6.5.
- [Release notes](https://github.com/fxn/zeitwerk/releases )
- [Changelog](https://github.com/fxn/zeitwerk/blob/main/CHANGELOG.md )
- [Commits](https://github.com/fxn/zeitwerk/compare/v2.6.4...v2.6.5 )
---
updated-dependencies:
- dependency-name: zeitwerk
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-06 23:42:49 +01:00
73d06c5149
Build(deps-dev): Bump selenium-webdriver from 4.5.0 to 4.6.1 ( #18900 )
...
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium ) from 4.5.0 to 4.6.1.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases )
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES )
- [Commits](https://github.com/SeleniumHQ/selenium/commits )
---
updated-dependencies:
- dependency-name: selenium-webdriver
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-06 23:41:28 +01:00
a56475a7a7
Build(deps-dev): Bump parallel_tests from 3.13.0 to 4.0.0 ( #18899 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from 3.13.0 to 4.0.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases )
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md )
- [Commits](https://github.com/grosser/parallel_tests/commits/v4.0.0 )
---
updated-dependencies:
- dependency-name: parallel_tests
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-06 23:41:00 +01:00
87c0d47c58
Build(deps-dev): Bump capybara from 3.37.1 to 3.38.0 ( #18897 )
...
Bumps [capybara](https://github.com/teamcapybara/capybara ) from 3.37.1 to 3.38.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases )
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md )
- [Commits](https://github.com/teamcapybara/capybara/compare/3.37.1...3.38.0 )
---
updated-dependencies:
- dependency-name: capybara
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-06 23:25:35 +01:00
dea44ec923
FEATURE: new site setting to hide user profiles by default. ( #18864 )
...
Previously, we didn't have a site-wide setting to set the default behavior for user profile visibility and user presence features. But we already have a user preference for that.
2022-11-06 16:44:17 +05:30
6f48502dd2
DEV: Add rake task to install a theme from an archive ( #18890 )
2022-11-04 16:42:07 -05:00
4542bf4fef
DEV: Fix greyed text for dark mode emails ( #18889 )
2022-11-04 15:44:49 -05:00
343037b022
FIX: Bug with permanent delete modal ( #18825 )
...
Repro steps:
- enable permanent deletes (via hidden site setting)
- set `min_topic_views_for_delete_confirm` to 0
When permanently deleting, the delete confirm modal is shown (for a
second time) and it doesn't pass the `force_destroy` parameter to the
request and the action results in a 422 error (i.e. can't perma-delete).
This change skips showing the confirm modal when perma-deleting given
that it has already been show on the first delete action.
2022-11-04 14:49:19 -04:00
2ae09db4aa
FIX: restore mention tab for experimental user nav ( #18882 )
2022-11-04 14:07:41 -04:00
b18ebc9648
PERF: Correct should_skip? logic in s3:upload ( #18862 )
...
This task is supposed to skip uploading if the asset is already present in S3. However, when a bucket 'folder path' was configured, this logic was broken and so the assets would be re-uploaded every time.
This commit fixes that logic to include the bucket 'folder path' in the check
2022-11-04 17:50:46 +00:00
38bb00edce
DEV: Use action helper in bulk-tag modal ( #18885 )
...
Passing a string action name to `DButton` causes it to use `sendAction`, which is deprecated and will be removed in Ember 4.x. The action helper converts a string to a closure action.
This also fixes compatibility with https://github.com/discourse/discourse/pull/17767
2022-11-04 17:26:31 +00:00
11f3618b80
DEV: initial system tests for chat and plugins ( #18881 )
...
This is a very basic to ensure it's working and open future possible work
2022-11-04 15:06:24 +01:00
518707c42a
DEV: Add .streerc file ( #18878 )
...
Chat plugin had this file, we can add it safely
without adding changes to CI so we can still run
syntax_tree on chat code manually.
2022-11-04 14:51:04 +10:00
65fd730fb1
Build(deps): Bump json_schemer from 0.2.22 to 0.2.23 ( #18872 )
...
Bumps [json_schemer](https://github.com/davishmcclurg/json_schemer ) from 0.2.22 to 0.2.23.
- [Release notes](https://github.com/davishmcclurg/json_schemer/releases )
- [Commits](https://github.com/davishmcclurg/json_schemer/compare/v0.2.22...v0.2.23 )
---
updated-dependencies:
- dependency-name: json_schemer
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-03 23:06:14 +01:00
868d503e84
Build(deps): Bump image_size from 3.1.0 to 3.2.0 ( #18873 )
...
Bumps [image_size](https://github.com/toy/image_size ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/toy/image_size/releases )
- [Changelog](https://github.com/toy/image_size/blob/master/CHANGELOG.markdown )
- [Commits](https://github.com/toy/image_size/compare/v3.1.0...v3.2.0 )
---
updated-dependencies:
- dependency-name: image_size
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-03 23:05:52 +01:00
69f15ed35c
Build(deps-dev): Bump mocha from 2.0.0 to 2.0.1 ( #18874 )
...
Bumps [mocha](https://github.com/freerange/mocha ) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/freerange/mocha/releases )
- [Changelog](https://github.com/freerange/mocha/blob/main/RELEASE.md )
- [Commits](https://github.com/freerange/mocha/compare/v2.0.0...v2.0.1 )
---
updated-dependencies:
- dependency-name: mocha
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-03 23:05:30 +01:00
36e0ecc79a
Build(deps): Bump rubocop-rspec from 2.14.2 to 2.15.0 ( #18875 )
...
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec ) from 2.14.2 to 2.15.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.14.2...v2.15.0 )
---
updated-dependencies:
- dependency-name: rubocop-rspec
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-03 23:05:05 +01:00
41eb92f5db
UX: Change ordering of categories shown in sidebar ( #18803 )
...
There are two possible ordering for categories shown in sidebar with
this commit.
When the `fixed_category_positions` site setting is enabled, the
categories are ordered based on `Category#position` which is a configurable
option by the user. When said site setting is disabled, the categories
are ordered based on `Category#name`.
The categories in Sidebar are also sorted in such a way where child
categories are always ordered right after their parents. When multiple
child categories are present, the child categories are ordered based on
the ordering described above.
2022-11-04 05:21:49 +09:00
291bbc4fb9
FIX: When cloning themes via HTTP, try the original URI too ( #18870 )
...
This should fix fetching from gitlab.
In order to get SSRF protection, we had to prevent redirects when cloning via git, but some repos are behind redirects and we want to support those too. We use `FinalDestination` before cloning to try to simulate git with redirects, but this isn't quite how git works, so there's some discrepancies between our SSRF protected cloning behavior and normal git behavior that I'm trying to work around.
This is temporary fix. It would be better to use `FinalDestination` to simulate the first request that git makes. I aim to make it work like that in the not too distant future, but this is better for now.
2022-11-03 15:19:08 -05:00
1398bd5f1f
FIX: Theme import error handling needs to happen inside the hijack block ( #18866 )
...
Otherwise the errors don't get caught.
2022-11-03 14:02:26 -05:00
943c43ddc5
UX: less link-like unread/new color in sidebar ( #18868 )
2022-11-03 14:57:01 -04:00
49a0129b0d
FIX: prevents chat to enter in endless loop when getting 404 ( #18867 )
...
Doing DOM operations in finally would cause them to happen even when the request was a failure. Consequence of these DOM operations would be new request, which would also end up in a 404, and so on.
This commit simply moves the DOM operations in the then block where it should be safe to make.
2022-11-03 19:52:44 +01:00
6e5e696c0b
DEV: Make modifyClass native class-aware, add tests ( #16111 )
2022-11-03 18:10:08 +01:00
c122c032bb
Ux sidebar muted icon ( #18856 )
...
* UX: sidebar muted channel opacity and colour change
* UX: visual state for active on muted channel
2022-11-03 16:00:21 +01:00
abcaa1a961
DEV: Rename direct message related models
...
This is a followup of the previous refactor where we created two new
models to handle all the dedicated logic that was present in the
`ChatChannel` model.
For the sake of consistency, `DMChannel` has been renamed to
`DirectMessageChannel` and the previous `DirectMessageChannel` model is
now named `DirectMessage`. This should help reasoning about direct
messages.
2022-11-03 14:39:23 +01:00
7e992cb299
Build(deps): Bump ember-source in /app/assets/javascripts ( #18859 )
...
Bumps [ember-source](https://github.com/emberjs/ember.js ) from 3.28.9 to 3.28.10.
- [Release notes](https://github.com/emberjs/ember.js/releases )
- [Changelog](https://github.com/emberjs/ember.js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/emberjs/ember.js/compare/v3.28.9...v3.28.10 )
---
updated-dependencies:
- dependency-name: ember-source
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-03 11:36:08 +00:00
f61e36384f
DEV: Use store.createRecord for Topic models ( #18837 )
...
…where possible
2022-11-03 12:32:20 +01:00
012eb922d5
Reduce theme/color-scheme cookie cookie duration ( #18858 )
...
Previously these were set to expire after 9999 days (27 years). This commit updates them to last 1 year, and to automatically be extended on every user visit.
2022-11-03 11:31:16 +00:00
3286d345f4
Build(deps): Bump @babel/standalone in /app/assets/javascripts ( #18851 )
...
Bumps [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ) from 7.20.0 to 7.20.1.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.20.1/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-03 12:30:45 +01:00
2f510cbd05
FIX: Do not limit scope to direct messages ( #18855 )
2022-11-03 09:17:23 +01:00
0028149ed4
UX: Add back button in chat browse screen on mobile ( #18849 )
2022-11-03 09:06:30 +01:00
9ff091dc01
FIX: the notification data on the client expects an identifier ( #18850 )
2022-11-03 09:06:05 +01:00
1c52e11d48
UX: scope chat-channel-title hover effect ( #18854 )
2022-11-03 09:04:57 +01:00
52be5b3782
DEV: Extend specs coverage for non-admin access to admin endpoints ( #18833 )
...
Replace base controller class inheritance specs with explicit specs
for non-staff and moderator access to admin resources
2022-11-03 03:42:44 +00:00
612ab8710a
DEV: Give em plugins the green tick ( #18836 )
2022-11-03 11:41:25 +08:00
49a191bf69
removed some extraneous question marks ( #18847 )
2022-11-03 10:26:27 +09:00
3ff18f2b3c
FIX: minor alignment fix for mobile small-actions ( #18853 )
2022-11-03 09:43:13 +09:00
d446ad3290
UX: Muted style for entire chat section link when muted ( #18852 )
2022-11-03 08:37:39 +09:00
391a456443
FIX: Write to group logs when a user is added to group by invite ( #18841 )
2022-11-03 07:58:12 +09:00
2e984f2eca
UX: Increase padding of back button in chat draft screen ( #18848 )
...
To increase hit target size for easier press on mobile devices
2022-11-02 21:28:41 +01:00
6c25b28312
DEV: Fix labeler.yml glob configuration ( #18846 )
...
Followup to 449f7d5ed5b32adf281e96a4d36ff3084f320817
2022-11-02 15:59:59 +00:00
8ed001678f
DEV: Have licensee check xmldom license ( #18840 )
2022-11-02 11:51:11 -04:00
449f7d5ed5
DEV: Automatically label chat PRs ( #18843 )
2022-11-02 15:43:59 +00:00
4201ca61e2
FIX: fix circle indicator on "my posts", color ( #18844 )
2022-11-02 11:43:28 -04:00
f6f436f694
FIX: New Topic button is now correctly disabled in a category where they have no permissions, even when filtered by tag ( #18741 )
2022-11-02 10:54:54 -04:00
954022aed2
DEV: Add chat plugin to Crowdin ( #18838 )
2022-11-02 15:18:02 +01:00
82425b23ee
Update translations ( #18813 )
2022-11-02 15:13:47 +01:00
0a5f548635
DEV: Move discourse-chat to the core repo. ( #18776 )
...
As part of this move, we are also renaming `discourse-chat` to `chat`.
2022-11-02 10:41:30 -03:00
e7e24843dc
DEV: Add integration specs for Github login ( #18808 )
...
Internal topic: t/82084.
2022-11-02 16:21:51 +03:00
