Commit Graph

30905 Commits

Author SHA1 Message Date
Sam
766e67ce57 FEATURE: introduce lossy color optimization on resized pngs
This feature ensures optimized images run via pngquant, this results extreme amounts of savings for resized images. Effectively the only impact is that the color palette on small resized images is reduced to 256.

To ensure safety we only apply this optimisation to images smaller than 500k.

This commit also makes a bunch of image specs less fragile.
2019-01-02 17:20:02 +11:00
Joe
2914431729 Improves admin and wizard logo copy
History:

https://meta.discourse.org/t/logo-recommended-resolution-tips/105053/6
2019-01-02 14:12:40 +08:00
Sam
14911d50a1 DEV: improve comment explaining need for favicon proxy 2019-01-02 13:15:20 +11:00
9e50813252 FIX: Pass all necessary options in migrate_to_s3 rake task. 2019-01-02 09:11:23 +08:00
0daaae1cf3 DEV: Fix rubocop after update. 2019-01-02 05:47:29 +08:00
828c07b658 Build(deps-dev): Bump rubocop from 0.60.0 to 0.61.1 (#6835) 2019-01-02 05:44:19 +08:00
2feeba0f1c DEV: Remove duplicated assertion. 2019-01-02 05:07:58 +08:00
96aca20fd7 add image optim version note to relevant tests 2019-01-01 01:25:00 -08:00
9878274427 Revert "Bump omniauth-google-oauth2 version"
This reverts commit 8ac0b721c541881d3726e051861df4ecb26afeb2.
2018-12-31 14:59:09 -05:00
8ac0b721c5 Bump omniauth-google-oauth2 version 2018-12-31 14:07:18 -05:00
23c65feb6c DEV: Prevent deprecation warnings being incorrectly logged 2018-12-31 14:41:30 +00:00
27ed60bad0 FIX: Quote selection in IE11 2018-12-31 13:54:05 +00:00
70fdc10365 FEATURE: move posts to new/existing PM (#6802) 2018-12-31 17:17:22 +05:30
b478984f60 make eslint happy 2018-12-31 12:38:45 +01:00
e49bcebb35 FIX: Validate poll arguments. (#6740)
* FIX: Validate number poll.
* FEATURE: Poll's min can be 0.
* FIX: Fix URL to user profile.
2018-12-31 10:48:30 +01:00
0fca3205b5 FIX: show error msg on grant badge if message available from backend (#6801) 2018-12-31 10:46:39 +01:00
1381dc603d UX: show generic message when reloading 'activation email resent' page 2018-12-31 13:12:37 +05:30
Joe
6fb421312e UX: aligns categories and tags in topic lists
History:

https://meta.discourse.org/t/minor-visual-weirdness-on-topic-listing-category-and-tags/105268
2018-12-31 14:38:33 +08:00
Joe
55d745f03b UX: header needs a bit of padding on narrow screens
A bit of history

https://meta.discourse.org/t/header-on-responsive-window/105204
2018-12-31 14:33:02 +08:00
8bd5c90b0c Bump logster to version 1.3.4 (#6834)
Fixes linear-gradient CSS issue on iOS
Increases z-index for the actions menu to prevent the screen divider/splitter from obstructing the menu

e43e98dc61
2018-12-31 06:58:46 +03:00
Sam
a19170a4c2 DEV: avoid require_dependency for some libs
This avoids require dependency on method_profiler and anon cache.

It means that if there is any change to these files the reloader will not pick it up.

Previously the reloader was picking up the anon cache twice causing it to double load on boot.

This caused warnings.

Long term my plan is to give up on require dependency and instead use:

https://github.com/Shopify/autoload_reloader
2018-12-31 10:53:30 +11:00
Sam
fef45789c4 DEV: improve docker dev environment
- pass USER=discourse which is not passed in from docker exec (improves backup restore)

- add unicorn script and unicorn support (expose port 9292)
2018-12-31 10:45:08 +11:00
021f11b68e FEATURE: Display avatars of PM recepients in small topic header when scrolling down 2018-12-30 20:10:40 +05:30
6578d56308 fix prettier offense (#6830) 2018-12-28 23:47:16 +01:00
72afefe211 FIX: calendar range was too wide (#6829) 2018-12-28 22:56:49 +01:00
e7cf642b1f FIX: reports issues with ie11 (#6828) 2018-12-28 21:32:07 +01:00
9a8db2748a FIX: composer css fixes for ie11 (#6827) 2018-12-28 20:52:21 +01:00
f1269fa807 FEATURE: Add Top Uploads report (#6825)
Co-Authored-By: I am very Pro-Grammer. <khalilovcmded@users.noreply.github.com>
2018-12-28 20:48:54 +01:00
608abd4c08 FIX: uses flex: 1 0 0; instead of flex: 1; for better browser compat (#6826) 2018-12-28 20:21:32 +01:00
7b15b87cf5 FIX: better left/right positioning in select-kit components (#6824) 2018-12-28 19:46:31 +01:00
0f09cb50e9 FIX: less fancy pages computation for browser compatibility (#6823) 2018-12-28 19:07:29 +01:00
4f6ca66df5 FIX: routeToTag mini-fix for IE11
skip "a.host" for IE11 since IE11 does not support URL interface
2018-12-28 11:49:51 -05:00
fdfb7ed764 FIX: Limit previous IE SVG click event fix
Fixes issues with clicking SVG icons in Safari, IE11, Edge
2018-12-28 10:18:53 -05:00
Joe
74f0bd08c0 UX: removes unnecessary margin in header tag wrapper
This margin is not needed and doesn't exist in the mobile view. 

It causes a bit of a problem in desktop topics with no categories and more prominently in PMs in the desktop view.

There's a small TODO here where the rest of the extra-info-wrapper styles should all be moved to header sylesheets.
2018-12-28 21:31:41 +08:00
523e0248e1 FIX: recurrence was not applied when selected in the form (#6820) 2018-12-28 12:36:49 +01:00
Joe
eaabbe5943 UX: improves help text for admin and wizard logo settings 2018-12-28 17:48:33 +08:00
942114b34c FIX: optimize collapse/expand select-kit codepath (#6818) 2018-12-27 23:38:01 +01:00
1d62d3df6f FIX: remove storage_stats from the list of reports, too specific (#6817) 2018-12-27 22:21:08 +01:00
695894d458 FIX: delete dataset doesn’t work on safari 2018-12-27 06:49:49 +02:00
8ce76460ed FIX: dates should also store recurring (#6814) 2018-12-26 23:35:10 +01:00
2b006c0429 FEATURE: Invalidate broken images cache on Rebuild HTML action 2018-12-26 23:22:07 +05:30
2076f371b3 FIX: Hashtags should work for non-english characters 2018-12-26 22:12:40 +05:30
5381096bfd PERF: new 'migrate_to_s3' rake task 2018-12-26 17:34:49 +01:00
8f65e4fb01 Bump logster to 1.3.3 (#6813)
Fixes a UI issue
2018-12-26 18:21:52 +03:00
303a535dba PERF: automatic upload size calculation not persisted
Previously if upload had missing width and height we would calculate
on first use BUT we (me) forgot to save this to the database

This was particularly bad on home page cause category images (when old)
miss dimensions.
2018-12-26 17:19:29 +02:00
f637286db5 UX: improves flags-status report (#6773)
- link to post
- cover more post action types
2018-12-26 10:29:33 +01:00
0402f0f357 UX: new site setting to define activity metrics displayed on dashboard 2018-12-26 10:29:07 +01:00
2ab02d6642 Bump logster version to 1.3.2 (#6811)
Logster 1.3.2 improves UX on mobile
2018-12-26 14:09:00 +08:00
69aa8f18c2 FEATURE: allow for custom excerpt BBCODE
This allows fidelity in controlling excerpt (text that shows up when you pin a topic or link to it externally):

```
I am some text

[excerpt]
This is some **custom** markdown that should be the excerpt
[/excerpt]

More text
```

Previous solution relied on DIVs, unfortunately DIVs do not play well,
by design with mixing markdown unless you have a preceding newline eg:

```
<div class='hello'>

this will be treated properly as markdown

</div>
```

This extra newline is not desirable.

I am also considering adding

```
[div class=excerpt]
[/div]
```

This would offer lots of flexibility to themes and plugins that do not want the extra annoying newline.
2018-12-25 17:02:28 +02:00
2cbb513c98 FIX: Don't use Redis#keys in production.
As per the documentation for KEYS

```
Warning: consider KEYS as a command that should only be used in production environments with extreme care. It may ruin performance when it is executed against large databases. This command is intended for debugging and special operations, such as changing your keyspace layout.
```

Instead SCAN

```
Since these commands allow for incremental iteration, returning only a small number of elements per call, they can be used in production without the downside of commands like KEYS or SMEMBERS that may block the server for a long time (even several seconds) when called against big collections of keys or elements.
```
2018-12-25 15:12:59 +02:00